fix(vuepress): fix Vuepress live preview plugin configuration based o… #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n latest version With the shift to the monorepo setup, this repository now runs on Node 14.x (due to the need for npm 7+). Switching to this version of Node JS has resulted in some packages (mainly vuepress-plugin-live and it's internal dependency vue-live) getting upgraded to newer versions. Currently, this repository's Vuepress implementation includes a custom template (www/.vuepress/previewLayout.vue) that over-rides vue-live's default template. This over-ride template was based on vue-live 0.3.0. The updated version of vue-live (1.3.0) uses a very different method to render a live code editor and hence it's template differs slightly - this difference in the template caused a visual/functional bug in the live-preview parts of the website's UI. This patch updates the over-ride template in accordance with the default template of vue-live 1.3.0 to fix this issue.
|
@asifahmedfw this PR fixes the Vuepress code preview breakage that we discussed today. The commit description captures the issue in detail. Please check and let me know if I've missed anything. @arvindanta FYI, it was due to the Node version change, but the breakage itself was difficult to trace. I had to dive into the implementation of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n latest version
With the shift to the monorepo setup, this repository now runs on Node 14.x (due to the need for npm
7+). Switching to this version of Node JS has resulted in some packages (mainly vuepress-plugin-live
and it's internal dependency vue-live) getting upgraded to newer versions. Currently, this
repository's Vuepress implementation includes a custom template (www/.vuepress/previewLayout.vue)
that over-rides vue-live's default template. This over-ride template was based on vue-live 0.3.0.
The updated version of vue-live (1.3.0) uses a very different method to render a live code editor
and hence it's template differs slightly (resulting in a series of CSS breakages) - this difference in the
template caused a visual/functional bug in the live-preview parts of the website's UI. This patch updates the
over-ride template in accordance with the default template of vue-live 1.3.0 to fix this issue.
Checklist:
How Has This Been Tested?