Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] - Support for forms #104

Closed
shakum3012 opened this issue Aug 12, 2020 · 2 comments · Fixed by #171
Closed

[Feature Request] - Support for forms #104

shakum3012 opened this issue Aug 12, 2020 · 2 comments · Fixed by #171
Assignees
@asif-ahmed-1990
Labels
enhancement New feature or request hacktoberfest This issue is open for hacktoberfest 2020 released on @next released

Comments

@shakum3012
Copy link

Describe the functionality of the new component:
The HTML form tag does go well with the existing crayons components. A mapping ie., field mapping is generated dynamically from the schema/fields present in the source and destination accounts. However, on form submit the ".serialize()" function doesn't give the form data. So, all the elements of the form have to be iterated to fetch the form data.

It will be great if "fw-form" web component is provided in the crayons.
@asif-ahmed-1990 asif-ahmed-1990 added the enhancement New feature or request label Aug 12, 2020
@asif-ahmed-1990 asif-ahmed-1990 added the hacktoberfest This issue is open for hacktoberfest 2020 label Sep 25, 2020
@asif-ahmed-1990 asif-ahmed-1990 self-assigned this Feb 3, 2021
asif-ahmed-1990 pushed a commit that referenced this issue Feb 3, 2021
feat(input, button, radio-group, textarea, datepicker, timepicker, ch…
fec2025 
…eckbox): added form support

Added form support. You can now use components inside form tag to send data via hidden input tag.

fix #104, fix #170
@asif-ahmed-1990 asif-ahmed-1990 mentioned this issue Feb 3, 2021
Merged
6 tasks
asif-ahmed-1990 pushed a commit that referenced this issue Feb 3, 2021
feat(input, button, radio-group, textarea, datepicker, timepicker, ch…
58a7d25 
…eckbox): added form support

Added form support. You can now use components inside form tag to send data via hidden input tag.

fix #104, fix #170
github-actions bot pushed a commit that referenced this issue Feb 3, 2021
@semantic-release-bot
chore(release): 2.12.0 [skip ci]
d097f35 
# [2.12.0](v2.11.1...v2.12.0) (2021-02-03)

### Features

* **input, button, radio-group, textarea, datepicker, timepicker, checkbox:** added form support ([58a7d25](58a7d25)), closes [#104](#104) [#170](#170)
@github-actions
Copy link

github-actions bot commented Feb 3, 2021

🎉 This issue has been resolved in version 2.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Feb 8, 2021

🎉 This issue has been resolved in version 2.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asif-ahmed-1990 asif-ahmed-1990

Labels
enhancement New feature or request hacktoberfest This issue is open for hacktoberfest 2020 released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(input, button, radio-group, textarea, datepicker, timepicker, ch… freshworks/crayons
2 participants
@shakum3012 @asif-ahmed-1990