MusicXML: \partial export as pickup measure #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a better solution than mine (#93), great work! I recommend adding a simple test for both cases. |
I thought the test files were only intended to compare the output with the MusicXML XSD schema, thanks for the recommendation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know there is a open request to recognize \partial feature, but what I'm proposing here is a bit different. Knowing that \partial is mainly recommended to add a pickup measure and in MusicXML a pickup measure is supposed to be numbered as "0", I implemented it as a feature. If the \partial is not in the first measure, the counting is unaltered.