Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dummy workflow to succeed DCO check on merge queues #366

Merged

Conversation

leandro-lucarella-frequenz
Copy link
Contributor

See #363 for
more details.

@leandro-lucarella-frequenz leandro-lucarella-frequenz added part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) type:enhancement New feature or enhancement visitble to users labels Apr 27, 2023
@leandro-lucarella-frequenz leandro-lucarella-frequenz added this to the v0.21.0 milestone Apr 27, 2023
@leandro-lucarella-frequenz
Copy link
Contributor Author

I re-enabled the DCO requirement for merging.

I set to merge when ready, lets see if it works!

@leandro-lucarella-frequenz leandro-lucarella-frequenz added this pull request to the merge queue Apr 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 27, 2023
@leandro-lucarella-frequenz leandro-lucarella-frequenz added this pull request to the merge queue Apr 27, 2023
The `generate-docs-pr` should also run for `merge_group` (and also
`workflow_dispatch`, why not?), so we change the `if` condition to only
exclude `push`es.

We also rename the job to `test-generate-docs` to make it more generic.

Signed-off-by: Leandro Lucarella <[email protected]>
@leandro-lucarella-frequenz
Copy link
Contributor Author

Added a commit to make generate-docs-pr run also for merge_group.

@leandro-lucarella-frequenz leandro-lucarella-frequenz removed this pull request from the merge queue due to a manual request Apr 27, 2023
@leandro-lucarella-frequenz leandro-lucarella-frequenz added this pull request to the merge queue Apr 27, 2023
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 27, 2023
@leandro-lucarella-frequenz leandro-lucarella-frequenz added this pull request to the merge queue Apr 28, 2023
Merged via the queue into frequenz-floss:v0.x.x with commit d3528e9 Apr 28, 2023
@leandro-lucarella-frequenz leandro-lucarella-frequenz deleted the dummy-dco-merge branch April 28, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) type:enhancement New feature or enhancement visitble to users
Projects
Development

Successfully merging this pull request may close these issues.

4 participants