Use solipsism, time-machine in *Pool tests
#1013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This eliminates flakiness coming from running tests in slow or software-emulated VMs. Signed-off-by: Sahas Subramanian <[email protected]>
github-actions
bot
added
the
part:tests
shsms
added
the
cmd:skip-release-notes
The PowerDistributor increases EV power only after a certain interval has passed. This change allows us to mock the passage of time, rather than waiting for the clock to move in real time. Signed-off-by: Sahas Subramanian <[email protected]>
Marenz
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the tests less flaky.
Closes #901