Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add datetime and Timestamp conversion functions #20

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Add datetime and Timestamp conversion functions #20

merged 1 commit into from
Feb 22, 2024

Conversation

Marenz
Copy link
Contributor

@Marenz Marenz commented Feb 19, 2024 •
edited
Loading

No description provided.

@Marenz Marenz requested a review from a team as a code owner February 19, 2024 17:46
@Marenz Marenz requested review from matthias-wende-frequenz and removed request for a team February 19, 2024 17:46
@github-actions github-actions bot added part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests labels Feb 19, 2024
@Marenz Marenz requested a review from llucax February 19, 2024 17:47
@github-actions github-actions bot added the part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) label Feb 19, 2024
@Marenz Marenz force-pushed the add-convert-func branch 2 times, most recently from c7241d7 to d098eb9 Compare February 20, 2024 09:35
llucax
llucax reviewed Feb 20, 2024
View reviewed changes
Copy link
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a few super minor comments, in particular the suggestion to add an optional timezone to to_datetime() can be done in a separate PR or wait until someone really needs it if it would take a non trivial amount of time to adapt the tests.

RELEASE_NOTES.md Outdated Show resolved Hide resolved
src/frequenz/client/base/conversion_helper.py Outdated Show resolved Hide resolved
tests/test_conversion.py Outdated Show resolved Hide resolved
@Marenz Marenz requested a review from llucax February 20, 2024 16:26
@Marenz Marenz added this pull request to the merge queue Feb 21, 2024
@Marenz Marenz removed this pull request from the merge queue due to a manual request Feb 21, 2024
@llucax llucax added this to the v0.2.0 milestone Feb 22, 2024
@llucax llucax added the type:enhancement New feature or enhancement visitble to users label Feb 22, 2024
@Marenz Marenz added this pull request to the merge queue Feb 22, 2024
Merged via the queue into frequenz-floss:v0.x.x with commit 33e9cfb Feb 22, 2024
15 checks passed
@Marenz Marenz deleted the add-convert-func branch February 22, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llucax llucax llucax approved these changes

@matthias-wende-frequenz matthias-wende-frequenz Awaiting requested review from matthias-wende-frequenz matthias-wende-frequenz is a code owner automatically assigned from frequenz-floss/python-sdk-team

Assignees

@Marenz Marenz

Labels
part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) type:enhancement New feature or enhancement visitble to users
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Marenz @llucax