FileWatcher: Don't type-check changes
#56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandro-lucarella-frequenz
added
the
type:tech-debt
leandro-lucarella-frequenz
requested a review
from sahas-subramanian-frequenz
github-actions
bot
added
the
part:core
leandro-lucarella-frequenz
force-pushed
the
fix-54
branch
from
eae0f04
to
47b2ee5
Compare
sahas-subramanian-frequenz
previously approved these changes
Nov 23, 2022
This check is unnecessary, as the underlying library is typed. This is not really signaling the closing of the "channel". Fixes frequenz-floss#54. Signed-off-by: Leandro Lucarella <[email protected]>
leandro-lucarella-frequenz
force-pushed
the
fix-54
branch
from
47b2ee5
to
1e09636
Compare
|
Not sure what's wrong with GitHub that is not picking up the action results, I will force-rebase and force-push to make the action run. |
|
Force-merging too as I didn't change anything since your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check is unnecessary, as the underlying library is typed. This is not really signaling the closing of the "channel".
Fixes #54.