Rename get_{sender,receiver} to new_{sender,receiver}
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandro-lucarella-frequenz
added
the
type:enhancement
leandro-lucarella-frequenz
requested a review
from sahas-subramanian-frequenz
github-actions
bot
added
part:channels
leandro-lucarella-frequenz
changed the title
get_{sender,receiver} to new_{sender,receiver}
leandro-lucarella-frequenz
force-pushed
the
no-get
branch
from
2d08227 to
b0a18d7
Compare
|
Rebased, ping @sahas-subramanian-frequenz |
shsms
previously approved these changes
Nov 22, 2022
Comment on lines
+17
to
+20
| * Channels methods `get_receiver()` and `get_sender()` have been renamed to | ||
| `new_receiver()` and `new_sender()` respectively. This is to make it more | ||
| clear that new objects are being created. | ||
|
|
There was a problem hiding this comment.
Should this be listed under Breaking changes?
There was a problem hiding this comment.
Added a (breaking changes) to Upgrading to make it more clear that this section list breaking changes. We can change the template if Upgrading is not clear enough. I used this to make it clear for people writing notes that it is important to say how to upgrade from breaking changes, not just listing them.
sahas-subramanian-frequenz
previously approved these changes
Nov 22, 2022
Using `get_` as a prefix gives the idea that one is always getting the same object, but these methods are indeed creating new objects. Signed-off-by: Leandro Lucarella <[email protected]>
leandro-lucarella-frequenz
dismissed stale reviews from sahas-subramanian-frequenz and shsms
via
ee3963d
leandro-lucarella-frequenz
force-pushed
the
no-get
branch
from
b0a18d7 to
ee3963d
Compare
leandro-lucarella-frequenz
requested a review
from sahas-subramanian-frequenz
sahas-subramanian-frequenz
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
get_as a prefix gives the idea that one is always getting the same object, but these methods are indeed creating new objects.