Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename OnlyIfPrevious as WithPrevious #355

Closed
llucax opened this issue Dec 2, 2024 · 0 comments · Fixed by #357
Closed

Rename OnlyIfPrevious as WithPrevious #355

llucax opened this issue Dec 2, 2024 · 0 comments · Fixed by #357
Labels
part:experimental Affects the experimental package type:enhancement New feature or enhancement visitble to users
Milestone
v1.4.0

Comments

@llucax
Copy link
Contributor

llucax commented Dec 2, 2024

What's needed?

Given #354, there is no more need to make it more clear if we are accepting messages for which the predicate returns True or False.

Proposed solution

Rename to WithPrevious.

Use cases

No response

Alternatives and workarounds

No response

Additional context

No response
@llucax llucax added part:experimental Affects the experimental package type:enhancement New feature or enhancement visitble to users labels Dec 2, 2024
@llucax llucax added this to the v1.4.0 milestone Dec 2, 2024
This was referenced Dec 2, 2024
Closed
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 4, 2024
@llucax
Rename OnlyIfPrevious to WithPrevious (#357)
56ae688 
The new name makes is more clear that this predicate is adding an extra
condition to the message filtering based on the previous message.

Fixes #355.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
part:experimental Affects the experimental package type:enhancement New feature or enhancement visitble to users
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging a pull request may close this issue.

Rename OnlyIfPrevious to WithPrevious llucax/frequenz-channels-python
1 participant
@llucax