Upgrade polkadot to latest stable-2506-2: Optimizations to FATx pool addressed#2559
Merged
saraswatpuneet merged 52 commits intomainfrom Sep 29, 2025
Merged
Upgrade polkadot to latest stable-2506-2: Optimizations to FATx pool addressed#2559saraswatpuneet merged 52 commits intomainfrom
saraswatpuneet merged 52 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
github-actions
bot
added
metadata-changed
github-actions
bot
added
the
metadata-changed
saraswatpuneet
temporarily deployed
to
github-pages
GitHub Actions
Inactive
JoeCap08055
reviewed
Aug 15, 2025
Collaborator
JoeCap08055
left a comment
JoeCap08055
left a comment
There was a problem hiding this comment.
If we're moving Rust versions, do we also need or want to update the nightly toolchain that we use for formatting and linting? It's specified in a couple places in the CI workflows, as well as the main Makefile.
github-actions
bot
added
metadata-changed
saraswatpuneet
requested review from
a team,
enddynayn,
mattheworris and
shannonwells
and removed request for
a team
github-actions
bot
added
the
metadata-version-not-incremented
saraswatpuneet
changed the title
github-actions
bot
added
metadata-changed
github-actions
bot
added
metadata-changed
saraswatpuneet
temporarily deployed
to
github-pages
GitHub Actions
Inactive
github-actions
bot
removed
the
metadata-changed
| fn alias_origin() -> Result<(xcm::benchmarks::Location, xcm::benchmarks::Location), BenchmarkError> { | ||
| Err(BenchmarkError::Skip) | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
nit: is this related to the sdk upgrade? Seems like an xcm related change.
Collaborator
Author
There was a problem hiding this comment.
@mattheworris yes these are newly added methods and following the change it seems this does not applies to us, @enddynayn there are come changes here that relates to xcm
mattheworris
approved these changes
Sep 24, 2025
Collaborator
mattheworris
left a comment
mattheworris
left a comment
There was a problem hiding this comment.
- Read through changes, non-blocking comment.
🚢 it!
aramikm
approved these changes
Sep 25, 2025
Collaborator
aramikm
left a comment
aramikm
left a comment
There was a problem hiding this comment.
Overall looks good. We need to make sure to upgrade all the nodes first and then we can do runtime upgrades due to using a new hostfunction inside the runtime.
| type WeightInfo = (); | ||
| type ConsensusHook = ConsensusHook; | ||
| type SelectCore = DefaultCoreSelector<Runtime>; | ||
| type RelayParentOffset = ConstU32<0>; |
Collaborator
There was a problem hiding this comment.
@enddynayn If you don't have any opinions I think we can keep this as 0. Feel free to close the comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to upgrade polkadot version to 2506-1
Following changes took place
RuntimeEventinConfigis being made redundant ( haven't removed it but added allow deprecated for now)runtume_interfacethat rust was warning about but it's polkadot design choice.Polkadot Notes on migration to 2506
Closes #2521
Discussion
fatxpool: limits handling optimizations and fixes paritytech/polkadot-sdk#8596Checklist