Fix zone services not working with YAML home zone #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
frenck
added
the
bugfix
|
tested, works now like expected 👍 |
|
Thanks for letting me know @martinhoess ❤️ ../Frenck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a workaround to get to the Zone storage collection.
Motivation and Context
Home Assistant doesn't set the Zone storage collection into the hass.data when the Home zone is defined/overriden in YAML. Causing Spook his zone services to fail.
This PR adds a workaround by grabbing the collection from the WebSocket API handlers. (Super dirty).
fixes #311
How has this been tested?
Defined the Home zone in YAML and restarted HA.
Confirmed the services now work, but don't work without the PR applied.
Screenshots (if appropriate):
Types of changes
Checklist