Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dockerfile #87

Merged
merged 5 commits into from
Mar 30, 2024
Merged

fix: Dockerfile #87

merged 5 commits into from
Mar 30, 2024

Conversation

GoliathLabs
Copy link
Member

@GoliathLabs GoliathLabs commented Mar 14, 2024

Description

Motivation and Context

How Has This Been Tested?

Screenshots/links:

Checklist:

  • My code follows the code style of this project. (CI will test it anyway and also needs approval)
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Dockerfile Outdated Show resolved Hide resolved
@T0biii
Copy link
Member

T0biii commented Mar 30, 2024

@GoliathLabs
Copy link
Member Author

I would now create a new branch from freifunk/main and make the important changes there like Add Config and Github Action Deploy I would rather see something like this DockerFile being opened upstream as a PR so that we don't just have the changes with us

following files should be added/adjusted to/for upstream

* https://github.com/freifunkMUC/meshviewer/blob/bbb03481dc2cc2df5201a8322102e3da36a18969/Dockerfile

* https://github.com/freifunkMUC/meshviewer/blob/73eb86bc7e5ec6ca1917ea7cc2efda446d8c123a/.github/workflows/docker.yml

* https://github.com/freifunkMUC/meshviewer/blob/73eb86bc7e5ec6ca1917ea7cc2efda446d8c123a/.github/workflows/build.yml

* https://github.com/freifunkMUC/meshviewer/blob/7f168658a5eef54a2659406744a73fc688243837/docker-compose.yml

Sounds like a good idea. Should I do the upstream PR or will you do it?

@GoliathLabs GoliathLabs merged commit 1dc60c1 into main Mar 30, 2024
4 checks passed
@GoliathLabs GoliathLabs deleted the GoliathLabs-patch-1 branch March 30, 2024 21:06
@T0biii
Copy link
Member

T0biii commented Mar 30, 2024

@GoliathLabs can you do the upstream pr pls :)

@GoliathLabs
Copy link
Member Author

freifunk#108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants