Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation notice for 8M flash devices #66

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Add deprecation notice for 8M flash devices #66

merged 1 commit into from
Dec 9, 2023

Conversation

grische
Copy link

@grische grische commented Dec 7, 2023

Description

Motivation and Context

freifunkMUC/site-ffm#327

How Has This Been Tested?

Screenshots/links:

Checklist:

  • My code follows the code style of this project. (CI will test it anyway and also needs approval)
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

@grische grische force-pushed the feature/filter-8m-flash-devices branch from 5a83baf to cf31b2a Compare December 7, 2023 23:18
T0biii
T0biii approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@T0biii T0biii left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the CI Error
I guess we still can merge this

@awlx awlx merged commit 945b4c7 into freifunkMUC:main Dec 9, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T0biii T0biii T0biii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grische @T0biii @awlx