mac80211: silence mesh rate mismatch warning #3416
Conversation
Printing a warning everytime a rate mismatch is detected is a bit to much. With many mesh neighbors, this quickly results in the kernel log being spammed with these messages. Signed-off-by: David Bauer <[email protected]>
|
I have a node with 2 mesh partners, which is directly spammed very much with these records - like 30 messages per second.
Is this normal without silencing it? What is needed to fix the mismatch warning? If both covr-x1860 are using latest gluon main - they should not have this warning anymore right? |
|
reboot did not help - there are only two COVR-X1860 seeing each other with gluon-main firmware. This looks like both would send with 40, but the peer receives a mesh rate of 1 in both directions..? |
| + ieee80211_sta_get_rates(sdata, ie, sband->band, | ||
| + &basic_rates); | ||
| + | ||
| +- if (sdata->vif.bss_conf.basic_rates != basic_rates) | ||
| +- return false; | ||
| ++ if (sdata->vif.bss_conf.basic_rates != basic_rates) { | ||
| ++ wiphy_warn(sdata->wdev.wiphy, |
There was a problem hiding this comment.
Would it help to use wiphy_warn_ratelimited instead?
See https://github.com/torvalds/linux/blob/v6.6/include/net/cfg80211.h#L9094-L9097
There was a problem hiding this comment.
Putting the warning in the first place was a bad idea, rate-limiting has no point in that.
Printing a warning everytime a rate mismatch is detected is a bit to much. With many mesh neighbors, this quickly results in the kernel log being spammed with these messages.