reset: ath79: fix reset sequence for AR9344 #3397
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to datasheet, on AR9344 the switch and switch analog need to be reset first before initiating a full reset. This fixes sporadic reboot issues. Instead of rebooting, the device will just hang. Without this patch, I had failed resets after 5, 20 and 250 tries. With this patch I have more than 2200 successful resets. Other chips like AR7100 do not have this specific requirement in the datasheet and also the meaning for bits 8 and 12 is slightly different, so only perform this sequence on AR9344. Signed-off-by: Nico Boehr <[email protected]>
|
This PR belongs upstream. The signed off in the commit message is currently missing, apart from that should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to datasheet, on AR9344 the switch and switch analog need to be reset first before initiating a full reset.
This fixes sporadic reboot issues. Instead of rebooting, the device will just hang. Without this patch, I had failed resets after 5, 20 and 250 tries. With this patch I have more than 2200 successful resets.
Other chips like AR7100 do not have this specific requirement in the datasheet and also the meaning for bits 8 and 12 is slightly different, so only perform this sequence on AR9344.
Fixes #2904