-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new target ipq807x-generic and new device Xiaomi AX3600 #3354
base: main
Are you sure you want to change the base?
Conversation
The Xiaomi AX3600 is officially supported by OpenWRT. As gluon just supports two WLAN radios the third one has to be disabled by removing the corresponding drivers
New target to support Xiaomi AX3600.
gluon-ffin-v2023.2.2+116-fastd-xiaomi_ax3600-sysupgrade.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
could you please edit your PR description so that the checklist renders properly?
Should just be a one to one copy and if you want to check something just change [ ]
to [x]
.
Of course it's fine to add comments where appropiate but proper formating allows for much better readability.
Also you'll have to add the target to .github/filters.yml
:
If you click on the "Show diff" CI Step you can see what and where you'll have to add it to make the CI pass.
:) Adding both kind of device descriptions to align with OpenWRT on the one side and the manufacturer ID on the other. Co-authored-by: Tom Herbers <[email protected]>
Thanks a lot for your kind support! A short explanation why some points are not marked as checked:
To get around the question if it would be better to use xiaomi_ax3600 oder xiaomi-ax3600 both labels are now supported. |
So this is also relying on #1661 as well. This would only get broken support, and it probably would be better to first work out functional support for devices with three radios in gluon.. :/ |
Hello, Generally it would be great if all radios (n) would get support. But I believe there is no reason to wait and the device is now available in the market with a lot of CPU power, WLAN6 and a good antenna array. If we have support for the ipq807 target it should be easy to support Xiaomi AX9000 as well. As far as I know one of the most powerful OpenWRT devices that serves 1000+ clients if needed. Just the secure boot thing and different layouts for CN and International version are unpleasant. |
Hallo Tom,
ich hatte gerade noch mal nachgesehen bezüglich der Syntax.
Wäre es nicht besser wenn wir die Schreibweisenfrage ausgliedern über den aliases Teil?
Beispiel im „read the docs“:
device('aruba-ap-303', 'aruba_ap-303', {
factory = false,
aliases = {'aruba-instant-on-ap11'},
})
>>also
device('xiaomi_ax3600', 'xiaomi-ax3600', {
aliases = {'xiaomi_ax3600'},
})
Leider geht die Benennung ob Bindestrich oder Unterstrich quer durcheinander, sodass ich vermute, dass egal welche Schreibweise wir festlegen würden es auch mal die falsche je nach Anwendungsfall ist und das Sysupgrade nur noch per force erreicht werden könnte... was unschön wäre.
Meine Variante hatte zumindest den Vorteil das kommend von OpenWRT es keine Rückfragen erzeugt.
Beste Grüße
Christian
Von: Tom Herbers ***@***.***>
Gesendet: Sonntag, 13. Oktober 2024 00:27
An: freifunk-gluon/gluon ***@***.***>
Cc: Christian Middendorf ***@***.***>; Author ***@***.***>
Betreff: Re: [freifunk-gluon/gluon] Adding new target ipq807x-generic and new device Xiaomi AX3600 (PR #3354)
@herbetom requested changes on this pull request.
Hi,
could you please edit your PR description so that the checklist renders properly?
Should just be a one to one copy <https://github.com/freifunk-gluon/gluon/wiki/Device-Integration-checklist> and if you want to check something just change [ ] to [x].
Of course it's fine to add comments where appropiate but proper formating allows for much better readability.
Also you'll have to add the target to .github/filters.yml:
https://github.com/freifunk-gluon/gluon/actions/runs/11308434515/job/31451274282
If you click on the "Show diff" CI Step you can see what and where you'll have to add it to make the CI pass.
_____
In targets/ipq807x-generic <#3354 (comment)> :
@@ -0,0 +1,11 @@
+-- Xiaomi
+
+device('xiaomi_ax3600', 'xiaomi_ax3600', {
⬇️ Suggested change
…-device('xiaomi_ax3600', 'xiaomi_ax3600', {
+device('xiaomi_ax3600', 'xiaomi-ax3600', {
probably
—
Reply to this email directly, view it on GitHub <#3354 (review)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/A7UN54APZ6H5AJKRS7QMM73Z3GOZRAVCNFSM6AAAAABP2WQ7MOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNRUGYZTOOJTGY> .
You are receiving this because you authored the thread. <https://github.com/notifications/beacon/A7UN54DNBKUESJMBA34TLJLZ3GOZRA5CNFSM6AAAAABP2WQ7MOWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUM6GBPA.gif> Message ID: ***@***.*** ***@***.***> >
|
@ChristianMiddendorf zum Verständnis was diese beiden Strings im Device bedeuten:
Das ist im Grunde auch hier beschrieben: Du müsstest es meines Erachtens nach also genau andersrum handhaben in deiner Config @herbetom |
The big problem that Blocktrron might still have with the target is that no one has added support for Gluon to handle the new regulatory domain (iw reg dm). |
Co-authored-by: Tom Herbers <[email protected]>
@Djfe we could postpone a decision by adding this platform as broken. I don't own such a platform and would like to make myself a better picture about the situation / implications (every information i have is from mailinglists and thus could be incomplete / incorrect). |
I'd would like/support such a decision. |
Good morning, |
@Djfe sorry, I did not realize the duplicate PR, thanks for the heads up.
What @blocktrron said. Originally posted by @AiyionPrime in #3032 (comment) |
@ChristianMiddendorf is there anything you would like @cawi2001 to test? |
sysupgrade [-n]
,firstboot
)(
lua -e 'print(require("platform_info").get_image_name())'
)(https://gluon.readthedocs.io/en/latest/dev/hardware.html#hardware-support-in-packages)
factory reset must be performed before checking the primary MAC address, as
the setting from the old version is not reset otherwise.
(https://gluon.readthedocs.io/en/latest/features/configmode.html)
is_outdoor_device
function inpackage/gluon-core/luasrc/usr/lib/lua/gluon/platform.lua
is_cellular_device
function inpackage/gluon-core/luasrc/usr/lib/lua/gluon/platform.lua
setup_ncm_qmi
topackage/gluon-core/luasrc/lib/gluon/upgrade/250-cellular
docs/user/supported_devices.rst