Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: net: dsa: mt7530: add support for bridge port isolation #3286

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

neocturne
Copy link
Member

@neocturne neocturne commented Jun 15, 2024

Adds bridge port isolation to MT7621-based devices like the Ubiquiti EdgeRouter-X.

Part of #2679.

@neocturne neocturne added 3. topic: hardware Topic: Hardware Support 0. type: bugfix This changeset fixes abug labels Jun 15, 2024
Adds bridge port isolation to MT7621-based devices like the Ubiquiti
EdgeRouter-X.
@github-actions github-actions bot removed the 3. topic: hardware Topic: Hardware Support label Jun 20, 2024
@neocturne
Copy link
Member Author

Updated to the version accepted for net-next and OpenWrt main

@neocturne neocturne marked this pull request as ready for review June 20, 2024 18:30
@rotanid
Copy link
Member

rotanid commented Jun 20, 2024

for me, stuff that was accepted in net-next and openwrt main doesnt need a further review by gluon maintainers, it's only a question about whether we want to backport it.
i'd say yes.

@neocturne
Copy link
Member Author

I did have to make some changes to the patches for 5.15, but yes, the main question is whether we want the backport.

@herbetom
Copy link
Contributor

herbetom commented Jul 1, 2024

Is there a reason to track this backport downstream and not in the OpenWrt repo? Seems like something that's not gluon specific.

Otherwise it seems justifiable to backport it.

@neocturne
Copy link
Member Author

Arguably it's a breaking change, so I'd rather not backport it to OpenWrt stable branches.

@herbetom
Copy link
Contributor

herbetom commented Jul 1, 2024

From my understanding bridge port isolation is only enabled if that setting has been enabled and AFAIK it's not by default in openwrt (only gluon enables it by default).
Therefore it should only break stuff if a user enabled it in the past, forgot about it and then it suddenly starts working. That doesn't really seem like a problem openwrt should care about.

@neocturne
Copy link
Member Author

The first patch affects all drivers, not just those that actually support the offloading; it also doesn't only affect port isolation, but also other bridge flags. It's difficult to say what the exact effects might be.

@rotanid
Copy link
Member

rotanid commented Jul 28, 2024

let's test in master, we can revert later if we have issues with this

@neocturne i suggest you try you build and if necessary refresh patch with current master branch and merge it youself

@neocturne
Copy link
Member Author

Status: I want to include the qca8k patches as well (not sure if they have been backported to OpenWrt main already)

@neocturne neocturne added the 2. status: waiting-on-author Waiting on some action from the author label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. type: bugfix This changeset fixes abug 2. status: waiting-on-author Waiting on some action from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants