Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional support for activeTab injection #44

Merged
merged 40 commits into from
Jan 18, 2023
Merged

Add optional support for activeTab injection #44

merged 40 commits into from
Jan 18, 2023

Conversation

fregante
Copy link
Owner

@fregante fregante commented Jan 8, 2023

Missing

@fregante fregante marked this pull request as ready for review January 8, 2023 17:33
@fregante fregante mentioned this pull request Jan 8, 2023
@fregante
Copy link
Owner Author

fregante commented Jan 8, 2023

CI fixed by #48 😮‍💨

active-tab.ts Outdated
export function onActiveTab(callback: (tab: ActiveTab) => void) {
startActiveTabTracking();
emitter.add(callback);
}
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is ready to be exported to a separate module, likely webext-events

}
}

onActiveTab(injectToTab);
Copy link
Owner Author

@fregante fregante Jan 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested:

  • via context menu
  • via browser action

Broken:

Edit: cross-origin iframes aren't covered by activeTab

including-active-tab.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically listen to activetab (optionally?)
1 participant