Make Mark All As Read optional #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
approved these changes
Aug 17, 2024
karlhorky
commented
Aug 17, 2024
karlhorky
commented
Aug 17, 2024
|
Apart from the approval by @tjx666, anything else I can do in this PR to make it ready? |
|
fine. |
|
Thanks for the review, merge and publish of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just noticed the new "Mark all as read" link that was added in this PR by @tjx666:
It seems like a nice feature! Maybe even good enough to be default for most users 👍
But for me (and maybe also others), it makes me nervous that I will accidentally click on it and mark everything as read. I often keep notifications as a kind of ad-hoc todo list for myself.
Also, it takes up extra vertical space, which I would like to avoid:
So I added an option (default: link enabled), which allows users to disable the link if they like.
cc @fregante what do you think?