Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: indicator doesn't update after mask as read #154

Merged
merged 7 commits into from
Aug 16, 2024

Conversation

tjx666
Copy link
Collaborator

@tjx666 tjx666 commented Aug 13, 2024

fix #147

@fregante fregante merged commit 7b35659 into fregante:master Aug 16, 2024
3 checks passed
@fregante
Copy link
Owner

Thank you 🙏

@euxx
Copy link

euxx commented Aug 21, 2024

Hi @tjx666 , thanks for handling this, but it seems there are still issues.

Notification status still doesn't get updated after clicking Mark as Read button.

I inspected the dot indicator and found --notifications-icon-indicator-display is always none, even when there are unread notifications.

image

I don't know how to debug extension locally, could you take another look?

@tjx666
Copy link
Collaborator Author

tjx666 commented Aug 21, 2024

@euxx Will investigate it when I have free time

@tjx666
Copy link
Collaborator Author

tjx666 commented Aug 23, 2024

@euxx #157

@euxx
Copy link

euxx commented Aug 23, 2024

@euxx #157

That's great. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification status doesn't update after clicking Mark as Read button
3 participants