Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid panic on filter with $ #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid panic on filter with $ #90

wants to merge 1 commit into from

Conversation

oshadmi
Copy link

@oshadmi oshadmi commented Feb 15, 2022

Fix #89

@oshadmi
Copy link
Author

oshadmi commented Feb 15, 2022

@freestrings
There is an option to throw an error on compile, but it seems that it is not the responsibility of the initial compilation/parsing.
Since the visitor/selector cannot fail gracefully, the suggested fix is to simply return an empty result.
WDYT?

@oshadmi
Copy link
Author

oshadmi commented Feb 22, 2022

@freestrings Hi, can you please review this fix?

@oshadmi oshadmi mentioned this pull request Feb 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash using Filter with $
1 participant
@oshadmi