Drop support for Ruby v2.1 #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 8, 2024
|
This page looks useful. As does bkeepers/dotenv#521. |
#694 was released in v2.7.1 a couple of weeks ago, so it should be safe to merge this now. |
This version has been EOL since 31 Mar 2017 [1], which is almost 8 years ago. `Mocha::Configuration#stubbing_method_on_nil` and `StubbingNilTest` are now moot, because as of Ruby v2.2 `nil` is frozen. The behaviour tested in the latter is already tested in the more generic `StubbingFrozenObjectTest`. See this commit [2] for details. Closes #628. [1]: https://www.ruby-lang.org/en/downloads/branches/ [2]: a65ea1e
floehopper
force-pushed
the
drop-support-for-ruby-v2.1
branch
2 times, most recently
from
cf72647 to
c8e8160
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby v2.1 has been EOL since 31 Mar 2017, which is almost 8 years ago.
Mocha::Configuration#stubbing_method_on_nilandStubbingNilTestare now moot, because as of Ruby v2.2nilis frozen. The behaviour tested in the latter is already tested in the more genericStubbingFrozenObjectTest. See this commit for details.Closes #628.