Move development dependencies from gemspec to Gemfile #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gemspec should not contain `RUBY_VERSION` as a condition to switch dependencies, because it is meaningless. Please see the following for details: - rubocop/rubocop#7137 - rubocop/ruby-style-guide#763 In addition, Bundler no longer uses `add_development_dependency` when genererating new gems. - rubygems/bundler#7222 For these reason, this PR moves development dependencies from gemspec to Gemfile.
mishina2228
commented
Apr 22, 2022
|
@mishina2228 This is great - thanks! I've tweaked your commit very slightly so the order of the gems in the two |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gemspec should not contain
RUBY_VERSIONas a condition to switch dependencies,because it is meaningless.
Please see the following for details:
In addition, Bundler no longer uses
add_development_dependencywhen genererating new gems.add_development_dependencyfrom new gems rubygems/bundler#7222For these reason, this PR moves development dependencies from gemspec to Gemfile.
The CI status can be seen here: https://app.circleci.com/pipelines/github/mishina2228/mocha/9/workflows/2c6bbae9-c2c8-44f7-bf86-2f0fb487b83d