feat(harvard_merger): add harvard_id field to OpinionCluster
#4622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`import_harvard_pdfs` has a `process_entry` method that is similar, but different from the entry processing in `process_crosswalk_file` and abandoned. Since a specialized method for processing an entry is useful, this patch reconciles the two bits of functionality. Finally, it adds a `--job` parameter to the command to make adding other jobs relating to CAP migration easier.
Harvard's Caselaw Access Project has been sunset. For projects which have existing references to CAP cases, there's a need to identify a CAP case's corresponding CL opinion cluster. An indexed `harvard_id` column is added to `OpinionCluster`. The field is also added to the `fields` of `OpinionClusterFilter`. For migration, this patch builds on work done in freelawproject#4284 and freelawproject#4442 and extends `import_harvard_pdfs` to populate the `harvard_id` column using CAP crosswalk file. Fixes: freelawproject#4313
cweider
commented
Oct 25, 2024
| self.assertTrue( | ||
| os.path.exists(crosswalk_dir), | ||
| f"Crosswalk directory does not exist: {crosswalk_dir}", | ||
| ) |
There was a problem hiding this comment.
Everything above is copy-paste from test_import_harvard_pdfs above. I don’t love it, but “good enough”? Nudge me if it needs to be better.
cweider
commented
Oct 25, 2024
| choices=["import_pdf"], | ||
| default="import_pdf", | ||
| help="", | ||
| ) |
There was a problem hiding this comment.
I see other things running through the crosswalk file to do work (#4614). I’ve no sound opinion for what the “correct” approach is. jobs here is driven by my interest in not copy/pasting (and then owning) the moderate complexity surrounding crosswalk processing. @jtmst, I’m happy to take any direction that you can give.
mlissner
requested changes
Oct 25, 2024
- Use better indexing approach - Use IntegerField - Make nullable
cweider
commented
Oct 26, 2024
| self.processed_pdfs.add(pdf_path) | ||
|
|
||
| except OpinionCluster.DoesNotExist: | ||
| logger.info(f"Cluster not found for id: {cl_cluster_id}") |
There was a problem hiding this comment.
Tempted to rely on the caller’s exception handler to do this logging ¯_(ツ)_/¯
|
@cweider The import_harvard_pdfs command has been updated, you may have conflicts in the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Harvard's Caselaw Access Project has been sunset. For projects which have existing references to CAP cases, there's a need to identify a CAP case's corresponding CL opinion cluster.
An indexed
harvard_idcolumn is added toOpinionCluster. The field is also added to thefieldsofOpinionClusterFilter.For migration, this patch builds on work done in #4284 and #4442 and extends
import_harvard_pdfsto populate theharvard_idcolumn using CAP crosswalk file.Fixes: #4313