Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(user): Adds fields to handle authentication. #257

Merged
merged 3 commits into from
Jun 8, 2023
Merged

feat(user): Adds fields to handle authentication. #257

merged 3 commits into from
Jun 8, 2023

Conversation

ERosendo
Copy link
Contributor

@ERosendo ERosendo commented Jun 1, 2023 •
edited
Loading

This PR adds three new fields to the User model. These fields are:

  • Activation_key
  • key_expires
  • Email_confirmed

These fields allow us to improve the user authentication process.

This PR also tweaks the admin interface for the user model to show the Email_confirmed field. We need to set this field to True for existing users before We merge #258.

@ERosendo
feat(user): Add new fields to the user model to handle auth
a3b2cc2 
This commit adds three new fields to the custom user model. These fields allow us to improve the user authentication process.
@ERosendo
feat(user): Add the email_confirmed field to the admin interface
ca7b340
@ERosendo ERosendo marked this pull request as ready for review June 1, 2023 16:51
@ERosendo ERosendo requested a review from mlissner June 1, 2023 16:51
mlissner
mlissner approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@mlissner mlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@mlissner mlissner enabled auto-merge June 8, 2023 22:53
@mlissner mlissner merged commit 9da9061 into main Jun 8, 2023
@mlissner mlissner deleted the feat-add-fields-to-handle-authentication branch June 8, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlissner mlissner mlissner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
@erosendo's backlog
Status: Done
@mlissner's backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ERosendo @mlissner