Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subscription): Add system for curators #210

Merged
merged 44 commits into from
May 2, 2023

Conversation

ERosendo
Copy link
Contributor

@ERosendo ERosendo commented Apr 24, 2023

This PR adds a new page to add cases and fixes #24.

This new page has a search bar to lookup for cases and a web form allowing curators to tweak the case name and add a summary.

Here's a gif showing this new page:

search-bar

@ERosendo ERosendo requested a review from mlissner April 25, 2023 12:44
@ERosendo ERosendo marked this pull request as ready for review April 25, 2023 12:44
Copy link
Member

@mlissner mlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm excited to use this. I think you've got the right direction, but I do have a handful of comments, as always.

The one thing that this will finally force us to deal with is our CDN. I think I managed to reconfigure it properly, but we're in new territory, so we'll have to watch closely to make sure that the "Add Case"/"Log in" button is always correct once this is deployed.

Good stuff though, thank you.

bc/subscription/utils/courtlistener.py Show resolved Hide resolved
bc/subscription/utils/courtlistener.py Show resolved Hide resolved
bc/subscription/views.py Show resolved Hide resolved
bc/subscription/views.py Outdated Show resolved Hide resolved
bc/assets/templates/includes/header.html Show resolved Hide resolved
bc/assets/static-global/js/htmx.min.js Outdated Show resolved Hide resolved
bc/assets/static-global/js/loading-states.js Outdated Show resolved Hide resolved
bc/assets/templates/base.html Outdated Show resolved Hide resolved
bc/subscription/templates/add-case.html Outdated Show resolved Hide resolved
@mlissner
Copy link
Member

By the way, the next thing we're going to want here is a search interface. I can see it coming and I'm sorry.

ERosendo added 11 commits May 1, 2023 10:28
This commit adds a new step to get the gateway IP of the bridge network created to connect all the containers of the project.
This commit adds two utility methods that helps us avoid repetition of the loop over the  enabled channels
This commit loads the non-minified version of the htmx file while debugging.
This commit adds a new variable called color to the button include. This variable allows us to tweak the background color of the include.
This commit replaces all the include tags that loads the yellow-button.html templates with the new action-button.html template.
@ERosendo ERosendo requested a review from mlissner May 1, 2023 22:42
Copy link
Member

@mlissner mlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there.

Wow there were a lot of tune ups when you added the enqueing for loops!

I need some help understanding the gateway stuff, and one small tweak, I think.

Thank you!

bc/subscription/utils/courtlistener.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
ARCHITECTURE.md Outdated Show resolved Hide resolved
bc/settings/django.py Show resolved Hide resolved
@ERosendo ERosendo requested a review from mlissner May 2, 2023 14:33
poetry.lock Outdated Show resolved Hide resolved
@ERosendo
Copy link
Contributor Author

ERosendo commented May 2, 2023

@mlissner thanks for your comments. I fixed the poetry.lock file, tweak the logic to get the Gateway IP, and added the debug toolbar as a dev dependency.

I checked the toolbar docs to update the settings module and the URLs file. I found out We needed it to add this script in pages that use HTMX.

@ERosendo ERosendo requested a review from mlissner May 2, 2023 16:54
Copy link
Member

@mlissner mlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There it is. Merging!

@mlissner mlissner merged commit 795ff6f into main May 2, 2023
@mlissner mlissner deleted the 24-add-system-for-curators branch May 2, 2023 16:59
@mlissner
Copy link
Member

mlissner commented May 2, 2023

Will you see if a quick PR is possible for CL to add the debug toolbar there too?

@ERosendo
Copy link
Contributor Author

ERosendo commented May 2, 2023

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add system for trusted curators to add cases to channels
2 participants