Automember > 'Host group rules' - Action buttons #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carma12
force-pushed
the
automem-host-group-action-buttons
branch
2 times, most recently
from
96ab28b to
66676ff
Compare
The 'Delete' button functionality must be implemented to handle the deletion of the Automember rules (User groups). Signed-off-by: Carla Martinez <[email protected]>
The Selector located in the toolbar should show the default group in the automembers page. This functionality should also allow to modify the default group via API command and show the new one. Signed-off-by: Carla Martinez <[email protected]>
The 'Add' button must allow the addition of new hostgroup rules to the table. Signed-off-by: Carla Martinez <[email protected]>
The 'Remove' button must manage the deletion of hostgroup rules in the table. Signed-off-by: Carla Martinez <[email protected]>
The default hostgroup functionality is handled through the selector located in the main toolbar. Signed-off-by: Carla Martinez <[email protected]>
carma12
force-pushed
the
automem-host-group-action-buttons
branch
from
66676ff to
0ba870a
Compare
carma12
added
needs-review
mreynolds389
approved these changes
Feb 11, 2025
The integration test should cover all use cases in the Automember > Hostgroup rules page. Signed-off-by: Carla Martinez <[email protected]>
carma12
force-pushed
the
automem-host-group-action-buttons
branch
from
0ba870a to
4bde204
Compare
Indeed. But I plan to implement this functionality (related to the Settings page) in a different PR. |
The `hostgroup_members.feature` test needs to use an already-created host group to perform the checks on operations. Also, there are some duplicated components in the `AutoMemUserRules` component (most likely due to a rebase) that need to be corrected. Signed-off-by: Carla Martinez <[email protected]>
carma12
force-pushed
the
automem-host-group-action-buttons
branch
from
a4c8c0b to
e7a2fd1
Compare
duzda
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The action buttons for the 'Hostgroup rules' page have been implemented. This includes:
This PR depends on this one to be merged: #628