This repository has been archived by the owner on Jan 6, 2022. It is now read-only.
Add site selections to the home page. #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This code looks pretty good, but I feel I need to more carefully consider the database setup to make sure I understand it and its ramifications. I am also not 100% sure that we want this feature - I envision a dynamically updating set of featured sites above the fold, rather than a static, fixed set. |
|
I think the downside of doing it dynamically is that you might have sites showing up on the homepage that don't have any kind of name recognition. I figured we would want to curate a set of highly recognizable news sites and then use those, either randomly or in order. |
|
Closing in favor of #32. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for a robust interface for selecting and ordering the homepage news sites. This is more complicated than a straightforward many-to-many because wagtail doesn't support editing many-to-many relationships (open bug). The through model is the workaround. See wagtail/wagtail#231 for more details.
