Actually enable systemd timers in securedrop-config package #7336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The magic `#DEBHELPER#` comment was missing from the securedrop-config postinst so the systemd timers were never being enabled.
3 tasks
|
I'm still working out what a regression test looks like. |
cfm
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Good catch, @legoktm! I'll approve this as is but defer to you for merge per #7336 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
The magic
#DEBHELPER#comment was missing from the securedrop-config postinst so the systemd timers were never being enabled.Testing
How should the reviewer test this PR?
ar x securedrop-config_2.11.0\~rc1+focal_all.deband thentar xvf control.tar.xz. Check that the postinst file has snippets like "Automatically added by dh_systemd_enable"Deployment
Any special considerations for deployment? n/a
Checklist