Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[admin CLI integration testing] securedrop-admin update #3460

Closed
redshiftzero opened this issue May 18, 2018 · 2 comments
Closed

[admin CLI integration testing] securedrop-admin update #3460

redshiftzero opened this issue May 18, 2018 · 2 comments
Assignees
Milestone

Comments

@redshiftzero
Copy link
Contributor

redshiftzero commented May 18, 2018

Description

We should have integration tests for the securedrop-admin update command. This command has a lot of unit tests, but the tests do a lot of mocking out of subprocess calls, I recommend examining those first.

Parent ticket: #3341

@kushaldas
Copy link
Contributor

While working on the integration test, I can see that gpg is sometimes failing to reach any keyserver, and throwing some cryptic error messages. Retrying the same a few times solved the issue.

INFO: Verifying signature on latest update...
gpg: directory '/tmp/.gnupg' created
gpg: keybox '/tmp/.gnupg/pubring.kbx' created
gpg: keyserver receive failed: Cannot assign requested address
gpg: keyserver receive failed: Cannot assign requested address
ERROR (run with -v for more): Command '['timeout', '45', 'gpg', '--recv-key', '--keyserver', 'hkps://hkps.pool.sks-keyservers.net', '22245C81E3BAEB4138B36061310F561200F4AD77']' returned non-zero exit status 2

While searching the error term, I found many other folks saw the same error message, one such example.

@redshiftzero @emkll please let me know your suggestions.

@kushaldas
Copy link
Contributor

I have code ready for PR, but, the above mentioned error is showing up randomly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants