Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add typecheck to CI #90

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

huyenltnguyen
Copy link
Member

@huyenltnguyen huyenltnguyen commented Apr 19, 2024

Checklist:

This PR adds typecheck to CI to prevent #88 from happening again, and also to enforce typechecking more strictly in general (which I wasn't able to do in the main repo).

Typecheck errors will now fail CI:

Screenshot 2024-04-19 at 13 02 31

@huyenltnguyen huyenltnguyen changed the title feat: add typecheck to ci feat: add typecheck to CI Apr 19, 2024
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You read my mind - I was thinking about creating this!

@huyenltnguyen huyenltnguyen marked this pull request as ready for review April 19, 2024 06:11
@huyenltnguyen huyenltnguyen requested a review from a team as a code owner April 19, 2024 06:11
@huyenltnguyen huyenltnguyen merged commit 37ef916 into freeCodeCamp:main Apr 19, 2024
5 checks passed
@huyenltnguyen huyenltnguyen deleted the feat/typecheck branch April 19, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants