Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: flatten dropdown folder #87

Merged
merged 3 commits into from
Apr 18, 2024
Merged

refactor: flatten dropdown folder #87

merged 3 commits into from
Apr 18, 2024

Conversation

huyenltnguyen
Copy link
Member

Checklist:

This PR:

  • Flattens the drop-down folder by moving /drop-down/menu-item/menu-item.tsx to /drop-down
  • Renames barrel files from index.tsx to index.ts, since the files don't include any JSX
  • Renames image.types.ts to types.ts for simplicity and consistency

@huyenltnguyen huyenltnguyen requested a review from a team as a code owner April 18, 2024 04:59
ojeytonwilliams
ojeytonwilliams approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ojeytonwilliams ojeytonwilliams merged commit 1e3252f into freeCodeCamp:main Apr 18, 2024
4 checks passed
@huyenltnguyen huyenltnguyen deleted the refactor/flatten-dropdown-dir branch April 18, 2024 08:08
@huyenltnguyen huyenltnguyen mentioned this pull request Apr 19, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojeytonwilliams ojeytonwilliams ojeytonwilliams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huyenltnguyen @ojeytonwilliams