Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add package build test to CI #338

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

huyenltnguyen
Copy link
Member

Checklist:

This PR adds a check to CI to ensure that dependencies upgrades won't break the package build (this was the case with #336, all CI checks were green but pnpm build would failed).

@huyenltnguyen huyenltnguyen marked this pull request as ready for review September 24, 2024 19:00
@huyenltnguyen huyenltnguyen requested a review from a team as a code owner September 24, 2024 19:00
@naomi-lgbt
Copy link
Member

We should add this to https://github.com/freeCodeCamp/ui/blob/main/.github/workflows/unit-tests.yml rather than an entirely separate action (refer to the main repo where we follow the same pattern)

@ojeytonwilliams ojeytonwilliams merged commit 3c1c1ac into freeCodeCamp:main Sep 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants