Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: lint and pre-commit hook with Husky and eslint #33

Merged
merged 11 commits into from
Apr 8, 2024
Merged

feat: lint and pre-commit hook with Husky and eslint #33

merged 11 commits into from
Apr 8, 2024

Commits on Apr 8, 2024

  1. feat: lint and pre-commit hook with Husky and eslint

    @Sembauke
    Sembauke committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    7de03f1 View commit details
    Browse the repository at this point in the history

  2. feat: add eslint config

    @Sembauke
    Sembauke committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    444aa31 View commit details
    Browse the repository at this point in the history

  3. fix: readd rollup plugin terser

    @Sembauke
    Sembauke committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    cdb598c View commit details
    Browse the repository at this point in the history

  4. fix: ignore dist, storybook-static and config files

    @Sembauke
    Sembauke committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    0c6b0ff View commit details
    Browse the repository at this point in the history

  5. feat: add some useful Eslint plugins

    @Sembauke
    Sembauke committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    d133e2a View commit details
    Browse the repository at this point in the history

  6. feat: add testing library react plugin

    @Sembauke
    Sembauke committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    7a04866 View commit details
    Browse the repository at this point in the history

  7. chore: fix eslint-react type issues 

    Our prop types are fine, but eslint-react isn't detecting them
correctly.

With a little help

jsx-eslint/eslint-plugin-react#3284 (comment)

we can tell it what the props are.
    @ojeytonwilliams
    ojeytonwilliams committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    8ea923a View commit details
    Browse the repository at this point in the history

  8. fix: add missing plugin

    @ojeytonwilliams
    ojeytonwilliams committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    6c1c337 View commit details
    Browse the repository at this point in the history

  9. fix: include eslint in linting

    @ojeytonwilliams
    ojeytonwilliams committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    39fd022 View commit details
    Browse the repository at this point in the history

  10. fix: use recommended rules

    @ojeytonwilliams
    ojeytonwilliams committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    37dbbac View commit details
    Browse the repository at this point in the history

  11. fix: upgrade warnings to errors 

    Same principle as the main repo: if we care enough for something to be a
rule, we want CI to tell us when it's not being followed.
    @ojeytonwilliams
    ojeytonwilliams committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    8c524f5 View commit details
    Browse the repository at this point in the history