Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deploy Storybook as documentation site (#26) #27

Merged
merged 6 commits into from
Apr 5, 2024

Conversation

Sembauke
Copy link
Member

@Sembauke Sembauke commented Apr 5, 2024

Checklist:

Closes #3

@Sembauke Sembauke requested a review from a team as a code owner April 5, 2024 09:48
.github/workflows/storybook-deploy.yml Outdated Show resolved Hide resolved
.github/workflows/storybook-deploy.yml Outdated Show resolved Hide resolved
.github/workflows/storybook-deploy.yml Outdated Show resolved Hide resolved
.github/workflows/storybook-deploy.yml Outdated Show resolved Hide resolved
.github/workflows/storybook-deploy.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On last thing: could you limit this to run pushes to main? I don't think we ever want other branches to trigger it.

Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Sembauke, this LGTM 👍

@Sembauke Sembauke merged commit 0cb840a into main Apr 5, 2024
5 checks passed
@Sembauke Sembauke deleted the test-github-pages branch April 5, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish the Storybook as a documentation site
2 participants