Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: configure for esm (#29)" #149

Merged
merged 1 commit into from
May 22, 2024

Conversation

ojeytonwilliams
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams commented May 22, 2024

This reverts commit 415d520.

Checklist:

No idea why moving this repo ESM breaks the learn client, but this should unblock releases until I figure it out.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] filesystem Transitive: environment, eval, network, shell, unsafe +30 9.45 MB nicolo-ribaudo
npm/[email protected] None 0 48.7 kB lencioni
npm/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +24 9.16 MB evilebottnawi
npm/[email protected] Transitive: environment, eval, filesystem +18 530 kB benmonro
npm/[email protected] filesystem Transitive: environment +10 971 kB simenb
npm/[email protected] Transitive: eval +79 7.74 MB ljharb
npm/[email protected] environment 0 118 kB react-bot
npm/[email protected] filesystem Transitive: environment, eval +86 5.73 MB ljharb
npm/[email protected] filesystem Transitive: environment +8 488 kB testing-library-bot
npm/[email protected] environment, filesystem Transitive: eval, shell, unsafe +70 9.46 MB eslintbot
npm/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +35 8.03 MB simenb
npm/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +119 6.45 MB simenb
npm/[email protected] environment Transitive: filesystem, shell +7 183 kB bret
npm/[email protected] Transitive: environment, filesystem +7 284 kB ryanzim
npm/[email protected] eval, unsafe Transitive: environment, filesystem, network, shell +18 8.98 MB evilebottnawi
npm/[email protected] environment +2 3.12 MB gaearon
npm/[email protected] environment +2 389 kB gaearon
npm/[email protected] environment Transitive: filesystem +11 334 kB egoist
npm/[email protected] None +1 1.26 kB shilman
npm/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +18 9.01 MB evilebottnawi
npm/[email protected] environment, filesystem +13 5.93 MB adamwathan
npm/[email protected] environment, filesystem, unsafe +3 2.85 MB blakeembrey
npm/[email protected] None +1 570 kB hirokiosame

View full report↗︎

@ojeytonwilliams ojeytonwilliams marked this pull request as ready for review May 22, 2024 16:56
@ojeytonwilliams ojeytonwilliams requested a review from a team as a code owner May 22, 2024 16:56
Copy link
Member

@huyenltnguyen huyenltnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writing this for posterity.

We tried upgrading the @freecodecamp/ui package to v1 in the /learn client, and pnpm develop there threw some errors:

  • ESM-related
    Screenshot 2024-05-23 at 00 04 49
  • React-related
    Screenshot 2024-05-22 at 16 04 30

The first error led us to the changes in #29, and git bisect also confirmed that is where the issue started. I'm not really sure how the second error is related to this change (the issue is there is a React 18 hook being included in the bundle, /learn is using React 16 and couldn't find that hook). But reverting #29 seems to resolve the issues (pnpm develop runs successfully).

@huyenltnguyen huyenltnguyen merged commit 5d1980b into freeCodeCamp:main May 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants