Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker-compose for development environment #76

Merged
merged 12 commits into from
Aug 14, 2023

Conversation

sidemt
Copy link
Member

@sidemt sidemt commented Aug 7, 2023

Checklist:

Closes #67

I referenced https://docs.strapi.io/dev-docs/installation/docker#optional-docker-compose for the example of docker-compose.yml.

@socket-security
Copy link

socket-security bot commented Aug 8, 2023

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

@sidemt sidemt changed the title Add cs import command Add docker-compose Aug 8, 2023
@sidemt sidemt marked this pull request as ready for review August 8, 2023 13:16
@sidemt sidemt requested a review from a team as a code owner August 8, 2023 13:16
@sidemt sidemt changed the title Add docker-compose Add docker-compose for development environment Aug 8, 2023
publish-backend/docker-compose.yml Outdated Show resolved Hide resolved
Copy link
Member

@raisedadead raisedadead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other general nitpick is the numbering scheme, why use only 1.?? 😅

docs/README.md Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
@zairahira

This comment was marked as outdated.

docs/README.md Outdated Show resolved Hide resolved
@raisedadead
Copy link
Member

Hey Mrugesh, this is a neat trick in Github markdown to get ordered numbers without worrying about the sequence :)

I am well aware of it 😅 - and it is an antipattern that we should not be following.

@sidemt
Copy link
Member Author

sidemt commented Aug 13, 2023

Hey Mrugesh, this is a neat trick in Github markdown to get ordered numbers without worrying about the sequence :)

I am well aware of it 😅 - and it is an antipattern that we should not be following.

Sorry I didn’t realize that we didn’t like that notation. Fixed.

Copy link
Member

@raisedadead raisedadead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the current vision for setup:

  1. Developer needs a Node.js Environment - Involves installing it natively
  2. Developer can spin the DB and Strapi Backend with Docker. We provide the compose setup for this.
  3. Developer uses separate terminals to do three basic things:
    • Startup the Strapi Backend
    • Startup the Nextjs (Frontend & API) local server
    • Run ad-hoc commands on the backend, like populating the DB, etc.

Please consider rearranging the steps for this.

Not a concern for this PR, the instructions are married to the folder structure. That should not be the case, as we refactor and rearrange things, it should be a good idea to break away from the naming.

See #81

@raisedadead raisedadead merged commit bf52eef into freeCodeCamp:main Aug 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker setup for Strapi app
3 participants