-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker-compose for development environment #76
Conversation
No top level dependency changes detected. Learn more about Socket for GitHub ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other general nitpick is the numbering scheme, why use only 1.
?? 😅
This comment was marked as outdated.
This comment was marked as outdated.
I am well aware of it 😅 - and it is an antipattern that we should not be following. |
Sorry I didn’t realize that we didn’t like that notation. Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the current vision for setup:
- Developer needs a Node.js Environment - Involves installing it natively
- Developer can spin the DB and Strapi Backend with Docker. We provide the compose setup for this.
- Developer uses separate terminals to do three basic things:
- Startup the Strapi Backend
- Startup the Nextjs (Frontend & API) local server
- Run ad-hoc commands on the backend, like populating the DB, etc.
Please consider rearranging the steps for this.
Not a concern for this PR, the instructions are married to the folder structure. That should not be the case, as we refactor and rearrange things, it should be a good idea to break away from the naming.
See #81
Checklist:
Update index.md
)Closes #67
I referenced https://docs.strapi.io/dev-docs/installation/docker#optional-docker-compose for the example of docker-compose.yml.