Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve cash register precision #602

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gikf
Copy link
Member

@gikf gikf commented Jun 23, 2024

Checklist:

Closes #559


@gikf gikf requested a review from a team as a code owner June 23, 2024 12:20
Copy link
Contributor

@lasjorg lasjorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlike the current demo code, this code always passes the new last test. I would suggest we merge this to make sure our demo project passes.


I see no issue with allowing _ as an unused var.

Co-authored-by: Naomi the Technomancer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cash Register Demo - floating-point error
3 participants