Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Clear the Empty spaces in /chapter route #1369

Merged
merged 16 commits into from
Aug 23, 2022
Merged

Conversation

sirasitxp
Copy link
Contributor

  • I have read Chapter's contributing guidelines.
  • My pull request has a descriptive title (not a vague title like Update README.md).
  • My pull request targets the main branch of Chapter.

Target for issue #1244

@sirasitxp sirasitxp requested a review from a team August 9, 2022 20:31
@gitpod-io
Copy link

gitpod-io bot commented Aug 9, 2022

@sirasitxp sirasitxp changed the title Redesign chapters page layout for issue #1244 Redesign: Chapters page layout for issue #1244 Aug 9, 2022
@ghost
Copy link

ghost commented Aug 9, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@gikf gikf added UI/UX This issue deals with UI/UX status: ready for review labels Aug 10, 2022
@Sboonny
Copy link
Member

Sboonny commented Aug 14, 2022

Hey, @hisnameispum because the current pull request won't support the current development for mvp, I am wondering if you can turn it into grid with 2 or more columns like mentioned in this comment

@sirasitxp
Copy link
Contributor Author

this comment

Got it!

@sirasitxp
Copy link
Contributor Author

@Sboonny I have redesigned the layout to be more like table list. Please let me know if it works for you.

Screen Shot 2022-08-16 at 1 29 42 PM

@Sboonny
Copy link
Member

Sboonny commented Aug 17, 2022

Sorry, looking back I was vague in my description.

Here is a quickly made layout in the figma of how the grid can look like
https://www.figma.com/file/o3BhXYjbJHb90Rbr4hlABP/Untitled?node-id=0%3A1

you can use Grid, GridItem in chakra to scale it easier in the future

https://chakra-ui.com/docs/components/grid/usage

@sirasitxp
Copy link
Contributor Author

sirasitxp commented Aug 17, 2022

I've just changed it from Flex to Grid, let me know if it works for you.

Copy link
Member

@Sboonny Sboonny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the hard work, and your patience

can you delete the two extra .env files, and revert the extra changes? I need something small

client/src/modules/chapters/pages/chaptersPage.tsx Outdated Show resolved Hide resolved
client/src/modules/chapters/pages/chaptersPage.tsx Outdated Show resolved Hide resolved
client/src/modules/chapters/pages/chaptersPage.tsx Outdated Show resolved Hide resolved
@sirasitxp
Copy link
Contributor Author

Thank you for the hard work, and your patience

can you delete the two extra .env files, and revert the extra changes? I need something small

Done! Let me know if you need me to do anything more.

Copy link
Member

@Sboonny Sboonny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component is used, but not imported. This is leading to error

@Sboonny Sboonny changed the title Redesign: Chapters page layout for issue #1244 Clear the Empty spaces in /chapter route Aug 19, 2022
Copy link
Member

@Sboonny Sboonny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉, thank you for your contribution to the page! 👍.

@Sboonny Sboonny merged commit 16df48c into freeCodeCamp:main Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: ready for review UI/UX This issue deals with UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants