-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some important changes #14
Open
peter279k
wants to merge
1
commit into
free-open-source:master
Choose a base branch
from
peter279k:psr2_coding_style
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter279k
force-pushed
the
psr2_coding_style
branch
from
May 11, 2019 18:48
ca5abf2
to
aca7811
Compare
peter279k
changed the title
Add StyleCI to check PSR-2 coding style
Some important changes
May 11, 2019
peter279k
force-pushed
the
psr2_coding_style
branch
from
May 11, 2019 18:53
aca7811
to
51b5de4
Compare
|
|
peter279k
force-pushed
the
psr2_coding_style
branch
from
May 12, 2019 09:33
51b5de4
to
9574c77
Compare
lablnet
approved these changes
Sep 8, 2020
This looks fine to me |
spekulatius
approved these changes
May 29, 2021
Hey @jenstornell any change this could be reviewed and merged? I'd like to use the package :) Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed log
ImageConverter
class.helper
function and letconvert
function split from theImageConverter
class.The completed Travis CI build log and StyleCI log are as follows: