Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved customization #13

Closed
wants to merge 12 commits into from
Closed

Conversation

gregcotten
Copy link

@gregcotten gregcotten commented Feb 12, 2021

Hi there! Thanks for making this.

I wanted to customize the page views a bit more so I added:

  1. Modernize PageScrollState to be stored as a @StateObject, bumping requirement to iOS 14 and watchOS 7.
  2. Make a PageViewSettings struct to encapsulate:
  • Existing preference for switchThreshold
  • Preference to dial in an "drag edge threshold" which is expressed as a ratio of the width or height of the page. The default value is 0.5, which allows the entire screen.
  • Preference for changing gesture types (.standard, .simultaneous, .highPriority, AND disable drag events entirely)
  1. Make a default PageViewSettings that matches the current behavior of the page view

@fredyshox fredyshox mentioned this pull request Sep 30, 2021
@fredyshox fredyshox closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants