Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check validity of arguments, better error messages. #6

Merged
merged 1 commit into from
Aug 23, 2019

Conversation

fredrikekre
Copy link
Owner

This segfaults Julia 1.0 so should not be merged until that is fixed, or until Julia 1.0 support is dropped.

@fredrikekre
Copy link
Owner Author

Hmm. Tests segfault on master with Julia 1.0.4 (https://github.com/fredrikekre/jlpkg/runs/196739829) even though there have been no changes to Julia code from https://github.com/fredrikekre/jlpkg/runs/148565014 so maybe this PR is not the problem.

@codecov-io
Copy link

Codecov Report

Merging #6 into master will decrease coverage by 4.47%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6      +/-   ##
=======================================
- Coverage   89.47%   85%   -4.48%     
=======================================
  Files           2     2              
  Lines          19    20       +1     
=======================================
  Hits           17    17              
- Misses          2     3       +1
Impacted Files Coverage Δ
src/cli.jl 0% <0%> (ø) ⬆️
src/jlpkg.jl 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8a77b8...a8a1163. Read the comment docs.

@fredrikekre fredrikekre merged commit 443b109 into master Aug 23, 2019
@fredrikekre fredrikekre deleted the fe/error-messages branch August 23, 2019 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants