RCON GetDvar: normalize CoD4x responses for unknown-cvar and color-coded values

[Copilot]

GetDvar could return raw RCON output when the quoted dvar format did not match, which breaks CoD4x behavior. This change normalizes CoD4x response text so unknown cvars map to not-found and returned values are stripped of Quake-style color tokens.

• Response normalization in RconController.GetDvar

  • Added color-code stripping before parsing (^0-^9, ^a-^z, ^A-^Z).
  • Parsing now runs on normalized text, avoiding leakage of raw formatted RCON output.
  • Uses compiled regex fields for consistent and efficient match/replace behavior.

• Unknown-cvar mapping

  • Detects normalized responses starting with Bad command or cvar:.
  • Returns API not-found for missing dvars instead of treating the raw text as a value.

• Error contract extension

  • Added DVAR_NOT_FOUND to ErrorCodes for explicit not-found semantics on dvar lookups.

• Focused unit coverage

  • Added RconControllerTests for:
    • unknown-cvar CoD4x response -> not found
    • numeric color code normalization
    • alphabetic color code normalization

var normalizedResponse = QuakeColorCodeRegex.Replace(response ?? string.Empty, string.Empty).Trim();

if (normalizedResponse.StartsWith("Bad command or cvar:", StringComparison.OrdinalIgnoreCase))
    return new ApiResponse<DvarValueDto>(
        new ApiError(ErrorCodes.DVAR_NOT_FOUND, $"The dvar '{dvarName}' was not found on the game server."))
        .ToNotFoundResult();

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[github-actions]

⛔ Superseded — A newer run has replaced this result.

⛔ Superseded — A newer run has replaced this result.

🏗️ Terraform Plan

🌍 Environment: dev

✅ Validate — Passed

✅ Plan

✅ No changes. Your infrastructure matches the configuration.

[Copilot]

Pull request overview

This PR normalizes GetDvar RCON responses so CoD/Quake-style color-coded output is parsed consistently and unknown dvars are returned as not found.

Changes:

• Adds compiled regex-based response normalization in RconController.GetDvar.
• Maps Bad command or cvar: responses to DVAR_NOT_FOUND.
• Adds focused unit tests for unknown dvars and numeric/alphabetic color-code stripping.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/XtremeIdiots.Portal.Integrations.Servers.Api.V1/Controllers/V1/RconController.cs	Normalizes GetDvar responses, strips Quake color codes, and returns not-found for unknown cvars.
src/XtremeIdiots.Portal.Integrations.Servers.Api.V1/Constants/ErrorCodes.cs	Adds DVAR_NOT_FOUND error code.
src/XtremeIdiots.Portal.Integrations.Servers.Api.Tests.V1/Controllers/RconControllerTests.cs	Adds unit tests covering CoD4x unknown-cvar and color-code normalization behavior.

[frasermolyneux]

@copilot - you need to pass a timeout in for the regex to fix the sonarcloud failures on the sonarcloud code analysis quality gate

[Copilot]

@copilot - you need to pass a timeout in for the regex to fix the sonarcloud failures on the sonarcloud code analysis quality gate

Implemented in 8354431: both new RconController compiled regexes now include TimeSpan.FromSeconds(1) timeouts to satisfy SonarCloud’s bounded-regex requirement.

[github-actions]

⛔ Superseded — A newer run has replaced this result.

🏗️ Terraform Plan

🌍 Environment: dev

✅ Validate — Passed

✅ Plan

✅ No changes. Your infrastructure matches the configuration.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

[github-actions]

🏗️ Terraform Plan

🌍 Environment: dev

✅ Validate — Passed

✅ Plan

	Count
➕ Add	6

📋 Resource Details

Action	Resource
➕ Create	azurerm_api_management_api_version_set.api_version_set
➕ Create	azurerm_api_management_product.api_product
➕ Create	azurerm_api_management_product_policy.api_product_policy
➕ Create	azurerm_linux_web_app.app_v1
➕ Create	azurerm_monitor_activity_log_alert.rg_resource_health
➕ Create	random_id.environment_id

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud