Implement caching rollout for portal-repo 4.2.21 - #52
Merged
Conversation
Dependency ReviewThe following issues were found:
License Issuessrc/XtremeIdiots.Portal.Server.Events.Processor.App/XtremeIdiots.Portal.Server.Events.Processor.App.csproj
OpenSSF Scorecard
Scanned Files
|
frasermolyneux
temporarily deployed
to
Development
August 2, 2026 20:00 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull request overview
This pull request rolls the processor app forward to portal-repo client 4.2.21 and enables the repository client’s built-in caching using the library default configuration, while updating unit tests to match an updated GetConnectedPlayers method signature.
Changes:
- Bumped
XtremeIdiots.Portal.Repository.Api.Client.V1to 4.2.21 andMX.Api.Clientto 2.3.76. - Enabled repository API client caching via
.WithCaching(c => c.UseLibraryDefaults())in the processor app startup. - Updated
ChatMessageProcessorTestsmock setup to include the newGetConnectedPlayersparameters.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/XtremeIdiots.Portal.Server.Events.Processor.App/XtremeIdiots.Portal.Server.Events.Processor.App.csproj |
Updates package references to pick up portal-repo 4.2.21 and related client changes. |
src/XtremeIdiots.Portal.Server.Events.Processor.App/Program.cs |
Enables repository client caching using library defaults during DI setup. |
src/XtremeIdiots.Portal.Server.Events.Processor.App.Tests/Functions/ChatMessageProcessorTests.cs |
Adjusts Moq setup to match updated GetConnectedPlayers signature. |
🏗️ Terraform Plan
✅ Validate — Passed ✅ Plan
📋 Resource Details
|
|
15 tasks
frasermolyneux
added a commit
that referenced
this pull request
Aug 2, 2026
…artup crash (#53) Repository 4.2.21 client-side caching policy composition throws ArgumentException: expression must invoke a method declared by IAdminActionsApi at DI build time. portal-sync and portal-repository-func are already crashing in production with this signature. portal-server-events main (PR #52) has the same registration and is subject to the same deterministic failure on restart. Removes only `.WithCaching(c => c.UseLibraryDefaults())` from Program.cs. BaseUrl + Entra ID authentication preserved. Repository server-side caching remains active. Player-context IMemoryCache, LiveStatus writes, moderation, VPN protection, welcome messages, and all event handling behaviour unchanged. Repository 4.2.21 / MX.Api 2.3.76 versions unchanged. Adds Startup/RepositoryApiClientRegistrationTests that build the production DI registration and resolve IRepositoryApiClient, IVersionedAdminActionsApi and every sub-client the processor calls at runtime (.V1 access forces the typed-client graph to materialise) so any regression in the AddRepositoryApiClient composition is caught before it reaches production. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements the consumer caching rollout for the portal-repo version 4.2.21 in the portal-server-events application. The following changes were made:
Updated Dependencies:
XtremeIdiots.Portal.Repository.Api.Client.V1from 4.2.16 to 4.2.21 andMX.Api.Clientfrom 2.3.75 to 2.3.76 in the project file.Enabled Caching:
.WithCaching(c => c.UseLibraryDefaults())to theAddRepositoryApiClient(...)method inProgram.csto enable caching with the specified defaults.Test Adjustments:
ChatMessageProcessorTeststo accommodate changes in theIConnectedPlayersApi.GetConnectedPlayersmethod signature while preserving existing behavioral expectations.Audit and Validation:
Validation:
This rollout aligns with the specified requirements and preserves the necessary caching behaviors while implementing the new version of the repository client.