Reject invalid demo uploads before storage by frasermolyneux · Pull Request #885 · frasermolyneux/portal-repository

frasermolyneux · 2026-10-03T18:32:33Z

Summary

update MX.CodDemoReader to 1.0.49 with the corrected CoD demo decoder
parse demo metadata before uploading to blob storage
return 422 Unprocessable Entity with INVALID_DEMO_FILE instead of persisting File corrupted! metadata
guarantee temporary upload cleanup and add regression coverage for valid and invalid processing paths

Validation

clean solution restore from NuGet.org using MX.CodDemoReader 1.0.49
Release solution build: 0 warnings, 0 errors
focused V1 demo tests: 9 passed on net9.0 and 9 passed on net10.0
formatting verification passed

Depends on the reader fix released by frasermolyneux/cod-demo-reader#36.

Parse demo metadata before blob upload and return a clear 422 response instead of persisting corrupted sentinel values. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b5220096-f71b-449f-b76a-f07fc9a5a4f4

github-actions · 2026-10-03T18:32:45Z

Dependency Review

The following issues were found:

✅ 0 vulnerable package(s)
✅ 0 package(s) with incompatible licenses
✅ 0 package(s) with invalid SPDX license definitions
⚠️ 2 package(s) with unknown licenses.

See the Details below.

License Issues

src/XtremeIdiots.Portal.Repository.Api.V1/XtremeIdiots.Portal.Repository.Api.V1.csproj

Package	Version	License	Issue Type
MX.CodDemoReader	1.0.49	Null	Unknown License

src/XtremeIdiots.Portal.Repository.Api.V2/XtremeIdiots.Portal.Repository.Api.V2.csproj

Package	Version	License	Issue Type
MX.CodDemoReader	1.0.49	Null	Unknown License

OpenSSF Scorecard

Package	Version	Score	Details
nuget/MX.CodDemoReader	1.0.49	Unknown	Unknown
nuget/MX.CodDemoReader	1.0.49	Unknown	Unknown

Scanned Files

src/XtremeIdiots.Portal.Repository.Api.V1/XtremeIdiots.Portal.Repository.Api.V1.csproj
src/XtremeIdiots.Portal.Repository.Api.V2/XtremeIdiots.Portal.Repository.Api.V2.csproj

Copilot

Copilot review overview

🟡 Changes recommended

The new 422 response is missing from OpenAPI metadata, and its error-code contract is not asserted.

Review effort: Balanced
Findings: 1 · 1

Open (2)

Document 422 response for SetDemoFile · New
Assert INVALID_DEMO_FILE error code in regression test · New

What changed in this PR

Updates V1 demo uploads to validate metadata before blob storage, using the corrected demo decoder.

Changes:

Upgrades MX.CodDemoReader to 1.0.49.
Adds a demo-processing service and returns 422 for invalid demos.
Ensures temporary-file cleanup and adds regression tests.

File	Description
`Api.V2.csproj`	Upgrades the demo reader dependency.
`Api.V1.csproj`	Upgrades the demo reader dependency.
`ServiceCollectionExtensions.cs`	Registers the processor service.
`IDemoFileProcessor.cs`	Defines processing contracts.
`DemoFileProcessor.cs`	Validates metadata before storage.
`DemosController.cs`	Handles invalid demos and cleans temporary files.
`DemoFileProcessorTests.cs`	Tests rejection before storage access.
`DemosControllerTests.cs`	Tests valid and invalid persistence paths.
`ApiErrorMessages.cs`	Adds the invalid-demo message.
`ApiErrorCodes.cs`	Adds `INVALID_DEMO_FILE`.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b5220096-f71b-449f-b76a-f07fc9a5a4f4

Copilot

Copilot review overview

🟢 Approval recommended

The implementation and tests consistently enforce validation before storage and expose the documented error contract.

Review effort: Balanced
Findings: None

Resolved since last review (2)

Document 422 response for SetDemoFile
Assert INVALID_DEMO_FILE error code in regression test

github-actions · 2026-10-03T18:49:12Z

Test results

Head: 032fea9e7230 | Tested: 4c2b37349dc3 | Run 37146316556, attempt 1

Job / report / suite	Status	Passed	Skipped	Total	TRX windows	Results
build-and-test / test_report / Unit	passed: Completed	1470	16	1486	48.056 s	TRX
build-and-test / v1_ci_test_report / Unit	passed: Completed	1470	16	1486	41.184 s	TRX
build-and-test / shared_tests_3_test_report / Unit	passed: Completed	1470	16	1486	37.199 s	TRX
build-and-test / integration_v1_test_report / Integration-V1	passed: Completed	15	0	15	4.574 s	TRX
build-and-test / integration_v2_test_report / Integration-V2	passed: Completed	4	0	4	1.785 s	TRX

Counts include each project/framework execution; summed TRX windows are not wall-clock time. No cross-suite totals are inferred.
The test/build jobs remain authoritative. Missing reports and unsuccessful job outcomes are never presented as passing.

github-actions · 2026-10-03T18:49:32Z

⛔ Superseded — A newer run has replaced this result.

🏗️ Terraform Plan

🌍 Environment: dev

✅ Validate — Passed

✅ Plan

	Count
➕ Add	23

📋 Resource Details

Action	Resource
➕ Create	`azurerm_api_management_api_version_set.api_version_set`
➕ Create	`azurerm_api_management_product.api_product`
➕ Create	`azurerm_api_management_product_policy.api_product_policy`
➕ Create	`azurerm_linux_web_app.app_v1`
➕ Create	`azurerm_linux_web_app.app_v2`
➕ Create	`azurerm_monitor_activity_log_alert.rg_resource_health`
➕ Create	`azurerm_mssql_database.database`
➕ Create	`azurerm_portal_dashboard.app`
➕ Create	`azurerm_portal_dashboard.staging_dashboard[0]`
➕ Create	`azurerm_role_assignment.app-to-storage`
➕ Create	`azurerm_role_assignment.app-to-storage-table`
➕ Create	`azurerm_role_assignment.workflow-sp-to-backup-storage`
➕ Create	`azurerm_storage_account.sql_backup_storage`
➕ Create	`azurerm_storage_account.table_storage`
➕ Create	`azurerm_storage_account.web_api_storage`
➕ Create	`azurerm_storage_container.demos_container`
➕ Create	`azurerm_storage_container.gametracker_container`
➕ Create	`azurerm_storage_container.map_images_container`
➕ Create	`azurerm_storage_container.sql_backups_container`
➕ Create	`azurerm_storage_management_policy.sql_backup_lifecycle`
➕ Create	`azurerm_storage_table.live_players`
➕ Create	`azurerm_storage_table.live_status`
➕ Create	`random_id.environment_id`

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b5220096-f71b-449f-b76a-f07fc9a5a4f4

Copilot

Copilot review overview

🟢 Approval recommended

The validation, storage ordering, API response contract, cleanup, dependency release, and regression coverage are aligned.

Review effort: Balanced
Findings: None

github-actions · 2026-10-03T18:59:20Z

⛔ Superseded — A newer run has replaced this result.

🏗️ Terraform Plan

🌍 Environment: dev

✅ Validate — Passed

✅ Plan

	Count
➕ Add	23

📋 Resource Details

Action	Resource
➕ Create	`azurerm_api_management_api_version_set.api_version_set`
➕ Create	`azurerm_api_management_product.api_product`
➕ Create	`azurerm_api_management_product_policy.api_product_policy`
➕ Create	`azurerm_linux_web_app.app_v1`
➕ Create	`azurerm_linux_web_app.app_v2`
➕ Create	`azurerm_monitor_activity_log_alert.rg_resource_health`
➕ Create	`azurerm_mssql_database.database`
➕ Create	`azurerm_portal_dashboard.app`
➕ Create	`azurerm_portal_dashboard.staging_dashboard[0]`
➕ Create	`azurerm_role_assignment.app-to-storage`
➕ Create	`azurerm_role_assignment.app-to-storage-table`
➕ Create	`azurerm_role_assignment.workflow-sp-to-backup-storage`
➕ Create	`azurerm_storage_account.sql_backup_storage`
➕ Create	`azurerm_storage_account.table_storage`
➕ Create	`azurerm_storage_account.web_api_storage`
➕ Create	`azurerm_storage_container.demos_container`
➕ Create	`azurerm_storage_container.gametracker_container`
➕ Create	`azurerm_storage_container.map_images_container`
➕ Create	`azurerm_storage_container.sql_backups_container`
➕ Create	`azurerm_storage_management_policy.sql_backup_lifecycle`
➕ Create	`azurerm_storage_table.live_players`
➕ Create	`azurerm_storage_table.live_status`
➕ Create	`random_id.environment_id`

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b5220096-f71b-449f-b76a-f07fc9a5a4f4

Copilot

Copilot review overview

🟢 Approval recommended

The validation, error contract, cleanup behavior, dependency update, and regression coverage are aligned with the stated purpose.

Review effort: Balanced
Findings: None

sonarqubecloud · 2026-10-03T19:07:07Z

Quality Gate passed

Issues
16 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-10-03T19:07:22Z

🏗️ Terraform Plan

🌍 Environment: dev

✅ Validate — Passed

✅ Plan

	Count
➕ Add	23

📋 Resource Details

Action	Resource
➕ Create	`azurerm_api_management_api_version_set.api_version_set`
➕ Create	`azurerm_api_management_product.api_product`
➕ Create	`azurerm_api_management_product_policy.api_product_policy`
➕ Create	`azurerm_linux_web_app.app_v1`
➕ Create	`azurerm_linux_web_app.app_v2`
➕ Create	`azurerm_monitor_activity_log_alert.rg_resource_health`
➕ Create	`azurerm_mssql_database.database`
➕ Create	`azurerm_portal_dashboard.app`
➕ Create	`azurerm_portal_dashboard.staging_dashboard[0]`
➕ Create	`azurerm_role_assignment.app-to-storage`
➕ Create	`azurerm_role_assignment.app-to-storage-table`
➕ Create	`azurerm_role_assignment.workflow-sp-to-backup-storage`
➕ Create	`azurerm_storage_account.sql_backup_storage`
➕ Create	`azurerm_storage_account.table_storage`
➕ Create	`azurerm_storage_account.web_api_storage`
➕ Create	`azurerm_storage_container.demos_container`
➕ Create	`azurerm_storage_container.gametracker_container`
➕ Create	`azurerm_storage_container.map_images_container`
➕ Create	`azurerm_storage_container.sql_backups_container`
➕ Create	`azurerm_storage_management_policy.sql_backup_lifecycle`
➕ Create	`azurerm_storage_table.live_players`
➕ Create	`azurerm_storage_table.live_status`
➕ Create	`random_id.environment_id`

Copilot AI balanced review requested due to automatic review settings October 3, 2026 18:32

Copilot started reviewing on behalf of frasermolyneux October 3, 2026 18:33

View session

Copilot AI reviewed Oct 3, 2026

View reviewed changes

Comment thread src/XtremeIdiots.Portal.Repository.Api.V1/Controllers/V1/DemosController.cs

Comment thread src/XtremeIdiots.Portal.Repository.Api.Tests.V1/Controllers/V1/DemosControllerTests.cs

Document invalid demo response

cb3b4f3

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b5220096-f71b-449f-b76a-f07fc9a5a4f4

Copilot AI balanced review requested due to automatic review settings October 3, 2026 18:38

Copilot started reviewing on behalf of frasermolyneux October 3, 2026 18:39

View session

Copilot AI reviewed Oct 3, 2026

View reviewed changes

frasermolyneux deployed to Development October 3, 2026 18:49 — with GitHub Actions Active

Harden temporary demo cleanup path

1246d4d

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b5220096-f71b-449f-b76a-f07fc9a5a4f4

Copilot AI balanced review requested due to automatic review settings October 3, 2026 18:50

Copilot started reviewing on behalf of frasermolyneux October 3, 2026 18:51

View session

Copilot AI reviewed Oct 3, 2026

View reviewed changes

frasermolyneux deployed to Development October 3, 2026 18:58 — with GitHub Actions Active

Isolate temporary file cleanup handle

032fea9

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b5220096-f71b-449f-b76a-f07fc9a5a4f4

Copilot AI balanced review requested due to automatic review settings October 3, 2026 19:00

Copilot started reviewing on behalf of frasermolyneux October 3, 2026 19:01

View session

Copilot AI reviewed Oct 3, 2026

View reviewed changes

frasermolyneux deployed to Development October 3, 2026 19:06 — with GitHub Actions Active

frasermolyneux merged commit 9d3ea2f into main Oct 3, 2026
22 checks passed

frasermolyneux deleted the fix/reject-invalid-demo-uploads branch October 3, 2026 19:30

This was referenced Oct 4, 2026

Bump the all-updates group with 5 updates frasermolyneux/portal-server-events#80

Merged

Bump the all-updates group with 9 updates frasermolyneux/portal-server-agent#98

Merged

Bump the all-updates group with 8 updates frasermolyneux/portal-web#249

Merged

Navigation Menu

Repository navigation

Reject invalid demo uploads before storage - #885

Reject invalid demo uploads before storage#885
frasermolyneux merged 4 commits into
mainfrom
fix/reject-invalid-demo-uploads

frasermolyneux commented Oct 3, 2026

Uh oh!

github-actions Bot commented Oct 3, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented Oct 3, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 3, 2026 •

edited

Loading

🏗️ Terraform Plan

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented Oct 3, 2026 •

edited

Loading

🏗️ Terraform Plan

Uh oh!

Copilot AI left a comment

Uh oh!

sonarqubecloud Bot commented Oct 3, 2026

Uh oh!

github-actions Bot commented Oct 3, 2026

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

frasermolyneux commented Oct 3, 2026

Summary

Validation

Uh oh!

github-actions Bot commented Oct 3, 2026

Dependency Review

License Issues

src/XtremeIdiots.Portal.Repository.Api.V1/XtremeIdiots.Portal.Repository.Api.V1.csproj

src/XtremeIdiots.Portal.Repository.Api.V2/XtremeIdiots.Portal.Repository.Api.V2.csproj

OpenSSF Scorecard

Scanned Files

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

github-actions Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test results

Uh oh!

github-actions Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🏗️ Terraform Plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

github-actions Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🏗️ Terraform Plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

sonarqubecloud Bot commented Oct 3, 2026

Quality Gate passed

Uh oh!

github-actions Bot commented Oct 3, 2026

🏗️ Terraform Plan

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Oct 3, 2026 •

edited

Loading

github-actions Bot commented Oct 3, 2026 •

edited

Loading

github-actions Bot commented Oct 3, 2026 •

edited

Loading