Migrate solution to .slnx and add DI/startup test coverage for observability registrations

.github/copilot-instructions.md

@@ -5,7 +5,7 @@ This repository publishes Application Insights observability packages for teleme
 ## Runtime and layout
 
 - SDK: `10.0.301` from `global.json`; package and test projects target `net9.0` and `net10.0`.
-- Solution: `src/MX.Observability.ApplicationInsights.sln`.
+- Solution: `src/MX.Observability.ApplicationInsights.slnx`.
 - Core package: `MX.Observability.ApplicationInsights`.
 - Adapters: `MX.Observability.ApplicationInsights.AspNetCore` and `MX.Observability.ApplicationInsights.WorkerService`.
 - Tests: `MX.Observability.ApplicationInsights.Tests`.
@@ -22,10 +22,10 @@ This repository publishes Application Insights observability packages for teleme
 ## Validation
 
 ```pwsh
-dotnet build src/MX.Observability.ApplicationInsights.sln
-dotnet test src/MX.Observability.ApplicationInsights.sln
-dotnet test src/MX.Observability.ApplicationInsights.sln --filter "FullyQualifiedName~MyTestClass.MyTestMethod"
-dotnet format src/MX.Observability.ApplicationInsights.sln --verify-no-changes
+dotnet build src/MX.Observability.ApplicationInsights.slnx
+dotnet test src/MX.Observability.ApplicationInsights.slnx
+dotnet test src/MX.Observability.ApplicationInsights.slnx --filter "FullyQualifiedName~MyTestClass.MyTestMethod"
+dotnet format src/MX.Observability.ApplicationInsights.slnx --verify-no-changes
 ```
 
 Usage and configuration contracts are documented in `README.md`.

AGENTS.md

@@ -4,7 +4,7 @@ Multi-target .NET observability libraries for Application Insights telemetry fil
 
 ## Locations
 
-- Solution: `src/MX.Observability.ApplicationInsights.sln`
+- Solution: `src/MX.Observability.ApplicationInsights.slnx`
 - Core package: `src/MX.Observability.ApplicationInsights`
 - Host adapters: `src/MX.Observability.ApplicationInsights.AspNetCore`, `src/MX.Observability.ApplicationInsights.WorkerService`
 - Tests: `src/MX.Observability.ApplicationInsights.Tests`
@@ -13,10 +13,10 @@ Multi-target .NET observability libraries for Application Insights telemetry fil
 ## Commands
 
 ```pwsh
-dotnet build src/MX.Observability.ApplicationInsights.sln
-dotnet test src/MX.Observability.ApplicationInsights.sln
-dotnet test src/MX.Observability.ApplicationInsights.sln --filter "FullyQualifiedName~MyTestClass.MyTestMethod"
-dotnet format src/MX.Observability.ApplicationInsights.sln --verify-no-changes
+dotnet build src/MX.Observability.ApplicationInsights.slnx
+dotnet test src/MX.Observability.ApplicationInsights.slnx
+dotnet test src/MX.Observability.ApplicationInsights.slnx --filter "FullyQualifiedName~MyTestClass.MyTestMethod"
+dotnet format src/MX.Observability.ApplicationInsights.slnx --verify-no-changes
 ```
 
 ## Constraints

src/MX.Observability.ApplicationInsights.Tests/AspNetCore/ServiceCollectionExtensionsTests.cs

@@ -0,0 +1,90 @@
+using Microsoft.AspNetCore.Hosting;
+using Microsoft.ApplicationInsights.AspNetCore;
+using Microsoft.ApplicationInsights.Channel;
+using Microsoft.ApplicationInsights.Extensibility;
+using Microsoft.Extensions.Configuration;
+using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.FileProviders;
+using Microsoft.Extensions.Options;
+using MX.Observability.ApplicationInsights.AspNetCore;
+using MX.Observability.ApplicationInsights.Auditing;
+using MX.Observability.ApplicationInsights.Filtering;
+using MX.Observability.ApplicationInsights.Filtering.Configuration;
+using MX.Observability.ApplicationInsights.Jobs;
+#pragma warning restore CS0618
+
+namespace MX.Observability.ApplicationInsights.Tests.AspNetCore;
+
+[Trait("Category", "Unit")]
+public class ServiceCollectionExtensionsTests
+{
+#pragma warning disable CS0618 // IHostingEnvironment is obsolete but still required by the Application Insights AspNetCore SDK's DI wiring.
+    private sealed class StubHostingEnvironment : IHostingEnvironment
+    {
+        public string EnvironmentName { get; set; } = "Development";
+        public string ApplicationName { get; set; } = "Tests";
+        public string WebRootPath { get; set; } = string.Empty;
+        public IFileProvider WebRootFileProvider { get; set; } = new NullFileProvider();
+        public string ContentRootPath { get; set; } = AppContext.BaseDirectory;
+        public IFileProvider ContentRootFileProvider { get; set; } = new NullFileProvider();
+    }
+#pragma warning restore CS0618
+
+    private sealed class NullTelemetryProcessor : ITelemetryProcessor
+    {
+        public void Process(ITelemetry item)
+        {
+        }
+    }
+
+    private static ServiceCollection CreateServicesWithApplicationInsights()
+    {
+        var services = new ServiceCollection();
+        services.AddSingleton<IConfiguration>(new ConfigurationBuilder().Build());
+#pragma warning disable CS0618 // IHostingEnvironment is obsolete but still required by the Application Insights AspNetCore SDK's DI wiring.
+        services.AddSingleton<IHostingEnvironment>(new StubHostingEnvironment());
+#pragma warning restore CS0618
+        services.AddApplicationInsightsTelemetry();
+        return services;
+    }
+
+    [Fact]
+    public void AddObservability_RegistersCoreServices()
+    {
+        var services = CreateServicesWithApplicationInsights();
+
+        services.AddObservability();
+        using var provider = services.BuildServiceProvider();
+
+        Assert.NotNull(provider.GetRequiredService<IAuditLogger>());
+        Assert.NotNull(provider.GetRequiredService<IJobTelemetry>());
+        Assert.NotNull(provider.GetRequiredService<IOptions<TelemetryFilterOptions>>().Value);
+    }
+
+    [Fact]
+    public void AddObservability_RegistersTelemetryFilterProcessorFactory()
+    {
+        var services = CreateServicesWithApplicationInsights();
+
+        services.AddObservability();
+        using var provider = services.BuildServiceProvider();
+
+        var factory = Assert.Single(provider.GetServices<ITelemetryProcessorFactory>());
+        var created = factory.Create(new NullTelemetryProcessor());
+
+        Assert.IsType<TelemetryFilterProcessor>(created);
+    }
+
+    [Fact]
+    public void AddObservability_WithConfigureFiltering_AppliesOverrides()
+    {
+        var services = CreateServicesWithApplicationInsights();
+
+        services.AddObservability(options => options.Enabled = false);
+        using var provider = services.BuildServiceProvider();
+
+        var options = provider.GetRequiredService<IOptions<TelemetryFilterOptions>>().Value;
+
+        Assert.False(options.Enabled);
+    }
+}

src/MX.Observability.ApplicationInsights.Tests/Extensions/ServiceCollectionExtensionsTests.cs

@@ -0,0 +1,104 @@
+using Microsoft.ApplicationInsights;
+using Microsoft.ApplicationInsights.Extensibility;
+using Microsoft.Extensions.Configuration;
+using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.Options;
+using Moq;
+using MX.Observability.ApplicationInsights.Auditing;
+using MX.Observability.ApplicationInsights.Extensions;
+using MX.Observability.ApplicationInsights.Filtering.Configuration;
+using MX.Observability.ApplicationInsights.Jobs;
+
+namespace MX.Observability.ApplicationInsights.Tests.Extensions;
+
+[Trait("Category", "Unit")]
+public class ServiceCollectionExtensionsTests
+{
+    private static ServiceCollection CreateServicesWithConfiguration()
+    {
+        var services = new ServiceCollection();
+        services.AddSingleton<IConfiguration>(new ConfigurationBuilder().Build());
+        services.AddSingleton(new TelemetryClient(new TelemetryConfiguration()));
+        return services;
+    }
+
+    [Fact]
+    public void AddObservabilityCore_RegistersAuditLoggerAndJobTelemetry()
+    {
+        var services = CreateServicesWithConfiguration();
+
+        services.AddObservabilityCore();
+        using var provider = services.BuildServiceProvider();
+
+        Assert.NotNull(provider.GetRequiredService<IAuditLogger>());
+        Assert.NotNull(provider.GetRequiredService<IJobTelemetry>());
+    }
+
+    [Fact]
+    public void AddObservabilityCore_WithEmptyConfiguration_BindsSafeDefaults()
+    {
+        var services = CreateServicesWithConfiguration();
+
+        services.AddObservabilityCore();
+        using var provider = services.BuildServiceProvider();
+
+        var options = provider.GetRequiredService<IOptions<TelemetryFilterOptions>>().Value;
+
+        Assert.True(options.Enabled);
+        Assert.NotNull(options.Dependencies);
+        Assert.NotNull(options.Requests);
+        Assert.NotNull(options.Traces);
+        Assert.NotNull(options.CustomEvents);
+    }
+
+    [Fact]
+    public void AddObservabilityCore_WithConfigureFiltering_AppliesOverrides()
+    {
+        var services = CreateServicesWithConfiguration();
+
+        services.AddObservabilityCore(options => options.Enabled = false);
+        using var provider = services.BuildServiceProvider();
+
+        var options = provider.GetRequiredService<IOptions<TelemetryFilterOptions>>().Value;
+
+        Assert.False(options.Enabled);
+    }
+
+    [Fact]
+    public void AddAuditLogging_RegistersAuditLoggerOnly()
+    {
+        var services = new ServiceCollection();
+        services.AddSingleton(new TelemetryClient(new TelemetryConfiguration()));
+
+        services.AddAuditLogging();
+        using var provider = services.BuildServiceProvider();
+
+        Assert.NotNull(provider.GetRequiredService<IAuditLogger>());
+        Assert.Null(provider.GetService<IJobTelemetry>());
+    }
+
+    [Fact]
+    public void AddJobTelemetry_RegistersJobTelemetryOnly()
+    {
+        var services = new ServiceCollection();
+        services.AddSingleton(new TelemetryClient(new TelemetryConfiguration()));
+        services.AddSingleton(Mock.Of<IAuditLogger>());
+
+        services.AddJobTelemetry();
+        using var provider = services.BuildServiceProvider();
+
+        Assert.NotNull(provider.GetRequiredService<IJobTelemetry>());
+    }
+
+    [Fact]
+    public void AddObservabilityCore_RegistersAuditLoggerAndJobTelemetryAsSingletons()
+    {
+        var services = CreateServicesWithConfiguration();
+
+        services.AddObservabilityCore();
+        using var provider = services.BuildServiceProvider();
+
+        Assert.Same(provider.GetRequiredService<IAuditLogger>(), provider.GetRequiredService<IAuditLogger>());
+        Assert.Same(provider.GetRequiredService<IJobTelemetry>(), provider.GetRequiredService<IJobTelemetry>());
+    }
+}

src/MX.Observability.ApplicationInsights.Tests/MX.Observability.ApplicationInsights.Tests.csproj

@@ -11,6 +11,7 @@
   <ItemGroup>
     <PackageReference Include="coverlet.collector" Version="10.0.1" />
     <PackageReference Include="coverlet.msbuild" Version="10.0.1" />
+    <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="10.0.11" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.9.0" />
     <PackageReference Include="Moq" Version="4.20.72" />
     <PackageReference Include="xunit" Version="2.9.3" />
@@ -24,8 +25,14 @@
     <Using Include="Xunit" />
   </ItemGroup>
 
+  <ItemGroup>
+    <FrameworkReference Include="Microsoft.AspNetCore.App" />
+  </ItemGroup>
+
   <ItemGroup>
     <ProjectReference Include="..\MX.Observability.ApplicationInsights\MX.Observability.ApplicationInsights.csproj" />
+    <ProjectReference Include="..\MX.Observability.ApplicationInsights.AspNetCore\MX.Observability.ApplicationInsights.AspNetCore.csproj" />
+    <ProjectReference Include="..\MX.Observability.ApplicationInsights.WorkerService\MX.Observability.ApplicationInsights.WorkerService.csproj" />
   </ItemGroup>
 
 </Project>

src/MX.Observability.ApplicationInsights.Tests/WorkerService/ServiceCollectionExtensionsTests.cs

@@ -0,0 +1,72 @@
+using Microsoft.ApplicationInsights.Channel;
+using Microsoft.ApplicationInsights.Extensibility;
+using Microsoft.ApplicationInsights.WorkerService;
+using Microsoft.Extensions.Configuration;
+using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.Options;
+using MX.Observability.ApplicationInsights.Auditing;
+using MX.Observability.ApplicationInsights.Filtering;
+using MX.Observability.ApplicationInsights.Filtering.Configuration;
+using MX.Observability.ApplicationInsights.Jobs;
+using MX.Observability.ApplicationInsights.WorkerService;
+
+namespace MX.Observability.ApplicationInsights.Tests.WorkerService;
+
+[Trait("Category", "Unit")]
+public class ServiceCollectionExtensionsTests
+{
+    private sealed class NullTelemetryProcessor : ITelemetryProcessor
+    {
+        public void Process(ITelemetry item)
+        {
+        }
+    }
+
+    private static ServiceCollection CreateServicesWithApplicationInsights()
+    {
+        var services = new ServiceCollection();
+        services.AddSingleton<IConfiguration>(new ConfigurationBuilder().Build());
+        services.AddApplicationInsightsTelemetryWorkerService();
+        return services;
+    }
+
+    [Fact]
+    public void AddObservability_RegistersCoreServices()
+    {
+        var services = CreateServicesWithApplicationInsights();
+
+        services.AddObservability();
+        using var provider = services.BuildServiceProvider();
+
+        Assert.NotNull(provider.GetRequiredService<IAuditLogger>());
+        Assert.NotNull(provider.GetRequiredService<IJobTelemetry>());
+        Assert.NotNull(provider.GetRequiredService<IOptions<TelemetryFilterOptions>>().Value);
+    }
+
+    [Fact]
+    public void AddObservability_RegistersTelemetryFilterProcessorFactory()
+    {
+        var services = CreateServicesWithApplicationInsights();
+
+        services.AddObservability();
+        using var provider = services.BuildServiceProvider();
+
+        var factory = Assert.Single(provider.GetServices<ITelemetryProcessorFactory>());
+        var created = factory.Create(new NullTelemetryProcessor());
+
+        Assert.IsType<TelemetryFilterProcessor>(created);
+    }
+
+    [Fact]
+    public void AddObservability_WithConfigureFiltering_AppliesOverrides()
+    {
+        var services = CreateServicesWithApplicationInsights();
+
+        services.AddObservability(options => options.Enabled = false);
+        using var provider = services.BuildServiceProvider();
+
+        var options = provider.GetRequiredService<IOptions<TelemetryFilterOptions>>().Value;
+
+        Assert.False(options.Enabled);
+    }
+}