Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(partner): Partnership Fees via dashboard #2377

Merged
merged 12 commits into from
Jan 6, 2025

Conversation

shadrak98
Copy link
Contributor

@shadrak98 shadrak98 commented Dec 21, 2024

This will allow partners to pay for Partnership renewal Fee directly from FC To enable this a new Invoice type and Balance Transaction Type called as Partnership Fee has been introduced.

image

ToDo:

  • Show Terms & Conditions check acting as Partner Agreement
  • Send Email on Successful renewal & Update renewal date

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 10.23622% with 114 lines in your changes missing coverage. Please review.

Project coverage is 38.34%. Comparing base (e49c4a9) to head (01007a5).

Files with missing lines Patch % Lines
press/api/partner.py 0.00% 55 Missing ⚠️
press/press/doctype/team/team.py 10.34% 26 Missing ⚠️
...razorpay_payment_record/razorpay_payment_record.py 10.00% 18 Missing ⚠️
press/api/billing.py 17.64% 14 Missing ⚠️
...doctype/balance_transaction/balance_transaction.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2377      +/-   ##
==========================================
- Coverage   38.46%   38.34%   -0.13%     
==========================================
  Files         377      377              
  Lines       29410    29529     +119     
==========================================
+ Hits        11313    11322       +9     
- Misses      18097    18207     +110     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shadrak98 shadrak98 changed the title feat(partner): Introducing Partnership Fees feat(partner): Partnership Fees via dashboard Dec 24, 2024
This will allow partners to pay for Partnership renewal Fee directly from FC
To enable this a new Invoice type and Balance Transaction Type called as Partnership Fee
has been introduced.
- Whitelist Press Settings and fields for partner portal on dashboard
- remove unnecessary details
- complete the Stripe payment flow
@shadrak98 shadrak98 merged commit 5e905e7 into frappe:master Jan 6, 2025
6 checks passed
@shadrak98 shadrak98 deleted the fc_partnership_fee branch January 6, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant