Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support to configure mariadb variables from dashboard #2335

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Merge branch 'master' into mariadb_variable_config_from_dashboard

e0b6198
Select commit
Loading
Failed to load commit list.
Draft

feat: Support to configure mariadb variables from dashboard #2335

Merge branch 'master' into mariadb_variable_config_from_dashboard
e0b6198
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 31, 2024 in 0s

38.54% (+0.00%) compared to 7100f48

View this Pull Request on Codecov

38.54% (+0.00%) compared to 7100f48

Details

Codecov Report

Attention: Patch coverage is 43.33333% with 17 lines in your changes missing coverage. Please review.

Project coverage is 38.54%. Comparing base (7100f48) to head (e0b6198).

Files with missing lines Patch % Lines
...press/doctype/mariadb_variable/mariadb_variable.py 42.10% 11 Missing ⚠️
...s/press/doctype/database_server/database_server.py 45.45% 6 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2335   +/-   ##
=======================================
  Coverage   38.54%   38.54%           
=======================================
  Files         377      377           
  Lines       29237    29266   +29     
=======================================
+ Hits        11270    11282   +12     
- Misses      17967    17984   +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov