fix: batch number search on pos #45209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabinhait
approved these changes
Jan 13, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
* fix: price of items with batch number not having seperate item price on pos search bar * fix: introduced batch number based sorting (cherry picked from commit e529f82)
ruthra-kumar
added a commit
that referenced
this pull request
Jan 14, 2025
…-45209 fix: batch number search on pos (backport #45209)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
## [15.48.4](v15.48.3...v15.48.4) (2025-01-15) ### Bug Fixes * auto fetch batch and serial no for draft stock transactions ([2f2554e](2f2554e)) * batch number search on pos ([#45209](#45209)) ([fe5c458](fe5c458)) * change string to be able to translate ([#45090](#45090)) ([7a3687c](7a3687c)) * deduct tds on excess amount if checked ([07c3605](07c3605)) * delivery_document_no column issue ([0df1808](0df1808)) * do not add ordered items from Quotation to new Sales Order ([f414fa4](f414fa4)) * don't create invoice if invoice start date is in future ([3f6d774](3f6d774)) * incorrect label in Item-wise sales register ([36d1fbd](36d1fbd)) * incorrect valuation for sales return with different warhouse ([9ee5651](9ee5651)) * incorrect valuation rate for PI based revaluation ([f7e3854](f7e3854)) * linter issue ([af21bca](af21bca)) * minor update for readability ([abfcfdf](abfcfdf)) * not able to see create Quality Inspection button ([a79cae1](a79cae1)) * pass right existing address ([80e6112](80e6112)) * precision loss causing process loss variance ([d84601b](d84601b)) * Semgrep rules ([1d5a73a](1d5a73a)) * set billing and shipping address on change of company ([42eb88f](42eb88f)) * Skip WIP Warehouse transfer ([bb0695a](bb0695a)) * test case ([f5667f5](f5667f5)) * test case ([7d66e4e](7d66e4e)) * tests ([8ba42cf](8ba42cf)) * timeout error for work order ([122b966](122b966)) * **Timesheet:** ignore permissions when updating Task and Project (backport [#45168](#45168)) ([#45170](#45170)) ([f7448c6](f7448c6)) * typo in manufacturing settings (backport [#45190](#45190)) ([#45193](#45193)) ([47c6e5a](47c6e5a)) * update discounting on mixed conditions ([38cb5a9](38cb5a9))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue related to items having batch numbers but no separate item price list for each batch number.
Before: If a separate price list was not set for each batch number, the price set to 0 would be shown if searched with the batch number on POS.
In the above screenshot, the item price with batch number "BRE0002" does not exist.
After: The Price is automatically set to the default Item Price (Item Price where no Batch Number is set).