Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phone number field when channel is phone on Payment Request doctype (copy #44949) #45081

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 3, 2025

This PR introduces enhancements to the Payment Request functionality in ERPNext, specifically targeted at phone-based payment channels like Mpesa STK Push. The feature allows the system to capture and process a phone number during payment requests, ensuring seamless integration with payment gateways. Fixing Issue #44945
image


Changes Implemented:

  1. Added Phone Number Field:

    • Introduced a new Phone Number field in the Payment Request doctype.
    • The field is conditionally visible and required when the selected payment channel is Phone.
  2. External Argument Handling:

    • Enhanced the system to accept a Phone Number via external arguments (e.g., from Webshop or POS).
  3. Integration with request_for_payment:

    • Included the Phone Number in the arguments passed to the request_for_payment method.
    • Ensured compatibility with the Mpesa Settings doctype, where the STK push process is initiated.

Key Benefits:

  1. Streamlined Payment Workflow:
    • Automatically captures and utilizes the payer’s phone number, removing manual intervention.
  2. Improved Integration:
    • Seamlessly supports Webshop and POS scenarios where phone numbers are essential for payment processing.
  3. Enhanced User Experience:
    • Enables real-time STK push payments, particularly useful for Mpesa and similar phone-based payment systems.

Should be merged to both versions 15+ going forward


This is an automatic copy of pull request #44949 done by [Mergify](https://mergify.com).

@mergify mergify bot added the conflicts label Jan 3, 2025
@mergify mergify bot requested a review from ruthra-kumar as a code owner January 3, 2025 23:54
Copy link
Contributor Author

mergify bot commented Jan 3, 2025

Cherry-pick of cfa062d has failed:

On branch mergify/copy/develop/pr-44949
Your branch is up to date with 'origin/develop'.

You are currently cherry-picking commit cfa062df86.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   erpnext/accounts/doctype/payment_request/payment_request.json
	both modified:   erpnext/accounts/doctype/payment_request/payment_request.py

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jan 3, 2025
@ruthra-kumar ruthra-kumar force-pushed the mergify/copy/develop/pr-44949 branch from ebf2de7 to 947ab72 Compare January 4, 2025 00:00
@ruthra-kumar ruthra-kumar self-assigned this Jan 6, 2025
@ruthra-kumar ruthra-kumar merged commit 2b88c13 into develop Jan 6, 2025
13 checks passed
@ruthra-kumar ruthra-kumar deleted the mergify/copy/develop/pr-44949 branch January 6, 2025 04:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants